Skip to content

Commit 8398c5d

Browse files
Fix feeHistory logic bug
It didn't converts blocks amount into hex number system.
1 parent 1a7734e commit 8398c5d

File tree

2 files changed

+17
-17
lines changed

2 files changed

+17
-17
lines changed

Sources/web3swift/Promises/Promise+Web3+Eth+FeeHistory.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import BigInt
1111

1212
extension web3.Eth {
1313
func feeHistory(blockCount: BigUInt, block: String, percentiles:[Double]) async throws -> Web3.Oracle.FeeHistory {
14-
let parameters: [JSONRPCParameter] = [blockCount.description.addHexPrefix(), block, percentiles]
14+
let parameters: [JSONRPCParameter] = [blockCount.hexString, block, percentiles]
1515

1616
let request = JSONRPCRequestFabric.prepareRequest(.feeHistory, parameters: parameters)
1717
let response = try await web3.dispatch(request)

Tests/web3swiftTests/remoteTests/GasOracleTests.swift

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ class OracleTests: XCTestCase {
1919
let web3 = await Web3.InfuraMainnetWeb3(accessToken: Constants.infuraToken)
2020
lazy var oracle: Web3.Oracle = .init(web3, block: .exact(blockNumber), blockCount: 20, percentiles: [10, 40, 60, 90])
2121
let etalonPercentiles: [BigUInt] = [
22-
71456911562, // 10 percentile
23-
92735433497, // 40 percentile
24-
105739785122, // 60 percentile
25-
118929912191 // 90 percentile
22+
94217344703, // 10 percentile
23+
105983352568, // 40 percentile
24+
110561015933, // 60 percentile
25+
124178275323 // 90 percentile
2626
]
2727

2828
let baseFeePercentiles = await oracle.baseFeePercentiles()
@@ -33,10 +33,10 @@ class OracleTests: XCTestCase {
3333
let web3 = await Web3.InfuraMainnetWeb3(accessToken: Constants.infuraToken)
3434
lazy var oracle: Web3.Oracle = .init(web3, block: .exact(blockNumber), blockCount: 20, percentiles: [10, 40, 60, 90])
3535
let etalonPercentiles: [BigUInt] = [
36-
1251559157, // 10 percentile
37-
1594062500, // 40 percentile
38-
2268157275, // 60 percentile
39-
11394017894 // 90 percentile
36+
1217066957, // 10 percentile
37+
1525000000, // 40 percentile
38+
2047260024, // 60 percentile
39+
9807181877 // 90 percentile
4040
]
4141

4242
let tipFeePercentiles = await oracle.tipFeePercentiles()
@@ -48,16 +48,16 @@ class OracleTests: XCTestCase {
4848
lazy var oracle: Web3.Oracle = .init(web3, block: .exact(blockNumber), blockCount: 20, percentiles: [10, 40, 60, 90])
4949
let etalonPercentiles: ([BigUInt], [BigUInt]) = (
5050
baseFee: [
51-
71456911562, // 10 percentile
52-
92735433497, // 40 percentile
53-
105739785122, // 60 percentile
54-
118929912191 // 90 percentile
51+
94217344703, // 10 percentile
52+
105983352568, // 40 percentile
53+
110561015933, // 60 percentile
54+
124178275323 // 90 percentile
5555
],
5656
tip: [
57-
1251559157, // 10 percentile
58-
1594062500, // 40 percentile
59-
2268157275, // 60 percentile
60-
11394017894 // 90 percentile
57+
1217066957, // 10 percentile
58+
1525000000, // 40 percentile
59+
2047260024, // 60 percentile
60+
9807181877 // 90 percentile
6161
]
6262
)
6363

0 commit comments

Comments
 (0)