Skip to content

Commit 76f381e

Browse files
authored
Merge pull request #4214 from fosscel/fix-s3-filesize
fix (S3): truncate byte buffer when putting object
2 parents 140b6ea + 8eb1ba4 commit 76f381e

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

DynmapCore/src/main/java/org/dynmap/storage/aws_s3/AWSS3MapStorage.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -138,9 +138,9 @@ public boolean write(long hash, BufferOutputStream encImage, long timestamp) {
138138
s3.deleteObject(req);
139139
}
140140
else {
141-
PutObjectRequest req = PutObjectRequest.builder().bucketName(bucketname).key(baseKey).contentType(map.getImageFormat().getEncoding().getContentType())
141+
PutObjectRequest req = PutObjectRequest.builder().bucketName(bucketname).key(baseKey).contentType(map.getImageFormat().getEncoding().getContentType())
142142
.addMetadata("x-dynmap-hash", Long.toHexString(hash)).addMetadata("x-dynmap-ts", Long.toString(timestamp)).build();
143-
s3.putObject(req, RequestBody.fromBytes(encImage.buf));
143+
s3.putObject(req, RequestBody.fromBytes(Arrays.copyOf(encImage.buf, encImage.len)));
144144
}
145145
done = true;
146146
} catch (S3Exception x) {
@@ -529,7 +529,7 @@ public boolean setPlayerFaceImage(String playername, FaceType facetype,
529529
}
530530
else {
531531
PutObjectRequest req = PutObjectRequest.builder().bucketName(bucketname).key(baseKey).contentType("image/png").build();
532-
s3.putObject(req, RequestBody.fromBytes(encImage.buf));
532+
s3.putObject(req, RequestBody.fromBytes(Arrays.copyOf(encImage.buf, encImage.len)));
533533
}
534534
done = true;
535535
} catch (S3Exception x) {
@@ -582,7 +582,7 @@ public boolean setMarkerImage(String markerid, BufferOutputStream encImage) {
582582
}
583583
else {
584584
PutObjectRequest req = PutObjectRequest.builder().bucketName(bucketname).key(baseKey).contentType("image/png").build();
585-
s3.putObject(req, RequestBody.fromBytes(encImage.buf));
585+
s3.putObject(req, RequestBody.fromBytes(Arrays.copyOf(encImage.buf, encImage.len)));
586586
}
587587
done = true;
588588
} catch (S3Exception x) {
@@ -611,8 +611,8 @@ public boolean setMarkerFile(String world, String content) {
611611
s3.deleteObject(delreq);
612612
}
613613
else {
614-
PutObjectRequest req = PutObjectRequest.builder().bucketName(bucketname).key(baseKey).contentType("application/json").build();
615-
s3.putObject(req, RequestBody.fromBytes(content.getBytes(StandardCharsets.UTF_8)));
614+
PutObjectRequest req = PutObjectRequest.builder().bucketName(bucketname).key(baseKey).contentType("application/json").build();
615+
s3.putObject(req, RequestBody.fromString(content));
616616
}
617617
done = true;
618618
} catch (S3Exception x) {
@@ -745,7 +745,7 @@ else if (fileid.endsWith(".js")) {
745745
ct = "application/x-javascript";
746746
}
747747
PutObjectRequest req = PutObjectRequest.builder().bucketName(bucketname).key(baseKey).contentType(ct).build();
748-
s3.putObject(req, RequestBody.fromBytes(content.buf));
748+
s3.putObject(req, RequestBody.fromBytes(Arrays.copyOf(content.buf, content.len)));
749749
standalone_cache.put(fileid, digest);
750750
}
751751
done = true;

0 commit comments

Comments
 (0)