Refactor to ensure script version is consistent everywhere (#96)

Author: quanglam2807

main-src/libs/app-management/install-app-async/index.js

@@ -12,6 +12,7 @@ const { getPreferences } = require('../../preferences');
 const sendToAllWindows = require('../../send-to-all-windows');
 const getEngineInfo = require('./get-engine-info');
 const getEngineAppPath = require('./get-engine-app-path');
+const packageJson = require('../../../../package.json');
 
 const prepareWebkitWrapperAsync = require('../prepare-webkit-wrapper-async');
 
@@ -60,7 +61,7 @@ const installAppAsync = (
 
       // use v2 script on Mac
       scriptFileName = 'install-app-forked-lite-v2.js';
-      v = '2.13.0';
+      v = packageJson.scriptVersion;
 
       return null;
     })

main-src/libs/app-management/install-app-async/install-app-forked-lite-v2.js

@@ -28,6 +28,7 @@ const execAsync = require('../../exec-async');
 const downloadAsync = require('../../download-async');
 const getEngineInfo = require('./get-engine-info');
 const getEngineAppPath = require('./get-engine-app-path');
+const packageJson = require('../../../../package.json');
 
 // id, name, username might only contain numbers
 // causing yargsParser to parse them correctly as Number instead of String
@@ -445,10 +446,10 @@ open -n "$PWD"/${addSlash(name)}.app --args --no-sandbox --test-type --app="${ur
     return Promise.reject(new Error('Unsupported platform'));
   })
   .then(() => {
-    const packageJson = JSON.stringify({
-      version: '2.13.0',
+    const packageJsonContent = JSON.stringify({
+      version: packageJson.scriptVersion,
     });
-    return fsExtra.writeFileSync(packageJsonPath, packageJson);
+    return fsExtra.writeFileSync(packageJsonPath, packageJsonContent);
   })
   .then(() => {
     const appJson = JSON.stringify({

package.json

@@ -2,6 +2,7 @@
   "name": "Chromeless",
   "description": "Turn Any Websites into Site-specific Browsers",
   "version": "4.2.1",
+  "scriptVersion": "2.13.0",
   "engines": {
     "node": ">=14.0.0 <15.0.0"
   },

src/components/shared/app-card.js

@@ -207,7 +207,7 @@ const AppCard = (props) => {
         visible: Boolean(engine && version),
       },
       {
-        label: `Powered by ${engineName} (implementation ${version})`,
+        label: `Powered by ${engineName} (script v${version})`,
         enabled: false,
         visible: Boolean(engine && version),
       },
@@ -332,7 +332,7 @@ const AppCard = (props) => {
           {renderActionsElement()}
         </div>
         {engineIcon && (
-          <Tooltip title={`Powered by ${engineName}${version ? ` (implementation ${version})` : ''}`}>
+          <Tooltip title={`Powered by ${engineName}${version ? ` (script v${version})` : ''}`}>
             <img src={engineIcon} alt={engineName} className={classes.topLeft} />
           </Tooltip>
         )}

src/state/app-management/utils.js

@@ -3,6 +3,7 @@
  * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
 import semver from 'semver';
 import { INSTALLING, INSTALLED } from '../../constants/app-statuses';
+import { scriptVersion } from '../../../package.json';
 
 export const isInstalledApp = (id, state) => {
   const { apps } = state.appManagement;
@@ -31,7 +32,7 @@ export const isOutdatedApp = (id, state) => {
   // app is Chromium/Firefox-based
   // check if app is installed with the latest version of forked-script-v2.js
   if (window.process.platform === 'darwin') {
-    return semver.lt(v, '2.13.0');
+    return semver.lt(v, scriptVersion);
   }
   // check if app is installed with the latest version of forked-script-v1.js
   return semver.lt(v, '1.8.0');