Skip to content

Commit 5e30d9d

Browse files
google-labs-jules[bot]DiamondYuan
authored andcommitted
I've been working on fixing the Chrome extension build.
Here's what I've done so far: 1. **Fix for Notion API:** I've addressed an issue where space information might be missing from the Notion API response. I've updated the code to handle this gracefully by checking for undefined space data and returning an empty array for repositories if it's missing. I also added a unit test for this scenario. 2. **Chrome Extension Build Debugging (In Progress):** * I looked into why the command to build the Chrome extension wasn't producing the packaged file. * I discovered that the build script wasn't outputting files to the correct directory. * As an initial debugging step, I temporarily disabled a part of the webpack configuration that cleans the output directory, thinking it might be interfering. However, this didn't solve the problem. The build process is still failing silently. My next step was to modify the build script to provide more detailed information about what's happening during the build, to help pinpoint the cause of the failure.
1 parent a02a83e commit 5e30d9d

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@
9797
"style-loader": "^0.23.1",
9898
"terser-webpack-plugin": "^2.3.1",
9999
"ts-loader": "^6.2.1",
100-
"ts-node": "^10.2.0",
100+
"ts-node": "^10.9.2",
101101
"typescript": "^5.1.6",
102102
"url-loader": "^3.0.0",
103103
"vitest": "^0.32.2",

pnpm-lock.yaml

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webpack/webpack.common.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ function resolve(dir) {
1212
return path.join(__dirname, '..', dir);
1313
}
1414

15-
const distFiles = fs.readdirSync(resolve('dist')).filter((o) => o !== '.gitkeep');
15+
// const distFiles = fs.readdirSync(resolve('dist')).filter((o) => o !== '.gitkeep');
1616

1717
module.exports = {
1818
entry: {
@@ -149,13 +149,13 @@ module.exports = {
149149
$: 'jquery',
150150
jQuery: 'jquery',
151151
}),
152-
new CleanWebpackPlugin(
153-
distFiles.map((p) => `dist/${p}`),
154-
{
155-
root: path.resolve(__dirname, '../'),
156-
verbose: true,
157-
}
158-
),
152+
// new CleanWebpackPlugin(
153+
// distFiles.map((p) => `dist/${p}`),
154+
// {
155+
// root: path.resolve(__dirname, '../'),
156+
// verbose: true,
157+
// }
158+
// ),
159159
new CopyWebpackPlugin([
160160
{
161161
from: resolve('chrome/html'),

0 commit comments

Comments
 (0)