feat: add package name #123
Open
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinfagnani
requested changes
May 6, 2024
| @@ -22,6 +22,11 @@ | |||
| * canonical export that should be used. | |||
| */ | |||
| export interface Package { | |||
| /** | |||
| * The name of the schema, it's best to be unique. | |||
There was a problem hiding this comment.
This should say that it's the name of the package.
We almost certainly want to namespace the package names too, since npm isn't the only package registry in town. We have at least GitHub, JSR, and internal repositories. We should discuss namespacing conventions in #119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #119