Commit 3d27b4e
committed
Fix closure compiler error
I'm trying to fix some bugs in the Closure compiler template type
checker. The fix has revealed a type error in shadydom, which this PR
attempts to fix.
With the fix, the following error occurs:
```
shadydom/src/patch-events.js:286:53: ERROR - [JSC_TYPE_MISMATCH] actual parameter 3 of Object.defineProperty does not match formal parameter
found : ObjectPropertyDescriptor<Event>
required: ObjectPropertyDescriptor<(Event|{
composed: ?,
composedPath: function(this:Event): ?,
relatedTarget: ?,
stopImmediatePropagation: function(this:Event): undefined,
stopPropagation: function(this:Event): undefined,
target: ?
})>
286| /** @type {!ObjectPropertyDescriptor<!Event>} */ ({
^^
287| /**
^^^^^^^^^
...
296| configurable: true,
^^^^^^^^^^^^^^^^^^^^^^^^^
297| })
^^^^^^
```
This error is correct because EventPatches is an object literal, which
can never be an Event because Event is a nominal type in Closure.
I think this change should be OK and will unblock Closure compiler
fixes.1 parent f91938f commit 3d27b4e
1 file changed
+8
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
283 | 283 | | |
284 | 284 | | |
285 | 285 | | |
286 | | - | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
287 | 294 | | |
288 | 295 | | |
289 | 296 | | |
| |||
0 commit comments