Merge pull request #537 from calebdwilliams/fix/method-return

fix(scoped-custom-elements-registry): return value from HTMLElement p…

Author: kevinpschaaf

packages/scoped-custom-element-registry/CHANGELOG.md

@@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-<!-- ## Unreleased -->
+## Unreleased
+
+### Fixed
+
+- Polyfilled ElementInternals prototype methods now return their original value.
 
 # [0.0.5] - 2022-02-18
 

packages/scoped-custom-element-registry/package-lock.json

@@ -486,7 +486,7 @@ if (!ShadowRoot.prototype.createElement) {
         const host = internalsToHostMap.get(this);
         const definition = definitionForElement.get(host);
         if (definition['formAssociated'] === true) {
-          originalMethod?.call(this, ...args);
+          return originalMethod?.call(this, ...args);
         } else {
           throw new DOMException(
             `Failed to execute ${originalMethod} on 'ElementInternals': The target element is not a form-associated custom element.`

packages/scoped-custom-element-registry/src/scoped-custom-element-registry.js

@@ -99,4 +99,22 @@ export const commonRegistryTests = (registry) => {
       expect(form.elements.length).to.equal(0);
     });
   });
+
+  describe('ElementInternals prototype method overrides', () => {
+    it('will still return the appropriate values', () => {
+      const {tagName, CustomElementClass} = getFormAssociatedTestElement();
+      registry.define(tagName, CustomElementClass);
+
+      const form = document.createElement('form');
+      const element = new CustomElementClass();
+
+      form.append(element);
+
+      expect(element.internals.checkValidity()).to.be.true;
+
+      element.internals.setValidity({valueMissing: true}, 'Test');
+
+      expect(element.internals.checkValidity()).to.be.false;
+    });
+  });
 };