Skip to content

Commit 4c5722c

Browse files
[site-server] Add 404 response for bad element paths (#1403)
1 parent c0c64e6 commit 4c5722c

File tree

17 files changed

+88
-17
lines changed

17 files changed

+88
-17
lines changed

package-lock.json

Lines changed: 17 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/catalog-api/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,7 @@
6161
"@graphql-codegen/cli": "^2.6.2",
6262
"@graphql-codegen/typed-document-node": "^2.2.8",
6363
"@graphql-codegen/typescript": "^2.4.8",
64-
"@graphql-codegen/typescript-resolvers": "^2.6.1",
65-
"uvu": "^0.5.6"
64+
"@graphql-codegen/typescript-resolvers": "^2.6.1"
6665
},
6766
"dependencies": {
6867
"@graphql-tools/schema": "^9.0.4",

packages/catalog-server/src/test/lib/firestore/firestore-repository_test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import {
1414
Package,
1515
} from 'custom-elements-manifest';
1616
import {suite} from 'uvu';
17+
// eslint-disable-next-line import/extensions
1718
import * as assert from 'uvu/assert';
1819

1920
import {FirestoreRepository} from '../../../lib/firestore/firestore-repository.js';

packages/catalog-server/src/test/lib/npm_test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
*/
66

77
import {suite} from 'uvu';
8+
// eslint-disable-next-line import/extensions
89
import * as assert from 'uvu/assert';
910
import {distTagListToMap, distTagMapToList} from '../../lib/npm.js';
1011

packages/custom-elements-manifest-tools/src/test/lib/get-custom-elements_test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import {readFile} from 'fs/promises';
88
import {fileURLToPath} from 'url';
99

1010
import {suite} from 'uvu';
11+
// eslint-disable-next-line import/extensions
1112
import * as assert from 'uvu/assert';
1213

1314
import type {Package} from 'custom-elements-manifest/schema.js';

packages/custom-elements-manifest-tools/src/test/lib/reference-string_test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
*/
66

77
import {suite} from 'uvu';
8+
// eslint-disable-next-line import/extensions
89
import * as assert from 'uvu/assert';
910
import {parseReferenceString} from '../../lib/reference-string.js';
1011

packages/custom-elements-manifest-tools/src/test/lib/resolve-reference_test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
import type {Package} from 'custom-elements-manifest/schema.js';
88
import {suite} from 'uvu';
9+
// eslint-disable-next-line import/extensions
910
import * as assert from 'uvu/assert';
1011
import {resolveReference} from '../../lib/resolve-reference.js';
1112

packages/custom-elements-manifest-tools/src/test/lib/validate_test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
*/
66

77
import {suite} from 'uvu';
8+
// eslint-disable-next-line import/extensions
89
import * as assert from 'uvu/assert';
910

1011
import {errorCodes, validatePackage} from '../../lib/validate.js';

packages/site-server/.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1-
lib
1+
/lib
2+
/test

packages/site-server/package.json

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@
1313
"build:server": "wireit",
1414
"check": "wireit",
1515
"start:dev": "wireit",
16-
"start:prod": "wireit"
16+
"start:prod": "wireit",
17+
"test": "wireit"
1718
},
1819
"wireit": {
1920
"build": {
@@ -35,7 +36,7 @@
3536
]
3637
},
3738
"build:server": {
38-
"command": "find src -name \"*.ts\" | xargs esbuild --format=esm --target=es2022 --color --outdir=lib",
39+
"command": "find src -name \"*.ts\" | xargs esbuild --format=esm --target=es2022 --color --outdir=.",
3940
"dependencies": [
4041
"../site-client:build:dev",
4142
"../custom-elements-manifest-tools:build",
@@ -66,17 +67,29 @@
6667
},
6768
"start:dev": {
6869
"command": "node --enable-source-maps ./lib/dev-server.js",
69-
"service": true,
70+
"service": {
71+
"readyWhen": {
72+
"lineMatches": "Web Dev Server started"
73+
}
74+
},
75+
"files": [],
7076
"dependencies": [
7177
"build:dev"
7278
]
7379
},
7480
"start:prod": {
7581
"command": "node --enable-source-maps ./lib/prod-server.js",
7682
"service": true,
83+
"files": [],
7784
"dependencies": [
7885
"build:prod"
7986
]
87+
},
88+
"test": {
89+
"command": "NODE_OPTIONS=--enable-source-maps uvu test \"_test\\.js$\"",
90+
"dependencies": [
91+
"start:dev"
92+
]
8093
}
8194
},
8295
"dependencies": {
@@ -96,5 +109,8 @@
96109
"koa-conditional-get": "^3.0.0",
97110
"koa-etag": "^4.0.0",
98111
"koa-static": "^5.0.0"
112+
},
113+
"devDependencies": {
114+
"uvu": "^0.5.6"
99115
}
100116
}

0 commit comments

Comments
 (0)