Skip to content
This repository was archived by the owner on Sep 20, 2019. It is now read-only.

Commit 1eb4e02

Browse files
committed
Remove rollup from closure compilation
Update closure to 20171023.0.1 Remove rollup from closure pass Save all Promise API when compiling
1 parent 9f0506d commit 1eb4e02

14 files changed

+687
-512
lines changed

gulpfile.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515

1616
const gulp = require('gulp');
1717
const sourcemaps = require('gulp-sourcemaps');
18-
const buffer = require('vinyl-buffer');
1918
const rename = require('gulp-rename');
2019
const rollup = require('rollup-stream');
2120
const source = require('vinyl-source-stream');
@@ -70,11 +69,12 @@ function closurify(sourceName, fileName) {
7069
};
7170

7271
return gulp.src([
73-
'entrypoints/*.js', 'src/*.js',
74-
'node_modules/es6-promise/lib/**/*.js',
75-
'node_modules/@webcomponents/**/*.js',
76-
'!node_modules/@webcomponents/*/externs/*.js'
77-
], {base: './'})
72+
'entrypoints/*.js',
73+
'src/*.js',
74+
'node_modules/es6-promise/lib/es6-promise/**/*.js',
75+
'node_modules/@webcomponents/**/*.js',
76+
'!node_modules/@webcomponents/*/externs/*.js'
77+
], {base: './'})
7878
.pipe(closure(closureOptions))
7979
.pipe(sourcemaps.write('.'))
8080
.pipe(gulp.dest('.'));

package-lock.json

Lines changed: 180 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@
3939
"eslint": "^4.9.0",
4040
"google-closure-compiler": "^20171023.0.1",
4141
"gulp": "^3.8.8",
42+
"gulp-add-src": "^0.2.0",
43+
"gulp-header": "^1.8.9",
4244
"gulp-rename": "^1.2.2",
4345
"gulp-sourcemaps": "^2.4.1",
4446
"rollup-plugin-babel": "^2.7.1",

src/promise.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ to work around https://github.com/webcomponents/webcomponentsjs/issues/837
1616
*/
1717
if (!window.Promise) {
1818
window.Promise = ES6Promise;
19-
// save catch function with a string name to prevent renaming and dead code eliminiation with closure
19+
// save Promise API
2020
ES6Promise.prototype['catch'] = ES6Promise.prototype.catch;
21+
ES6Promise.prototype['then'] = ES6Promise.prototype.then;
22+
ES6Promise['all'] = ES6Promise.all;
23+
ES6Promise['race'] = ES6Promise.race;
24+
ES6Promise['resolve'] = ES6Promise.resolve;
25+
ES6Promise['reject'] = ES6Promise.reject;
2126
}

0 commit comments

Comments
 (0)