Skip to content

Commit 2309e50

Browse files
committed
tweaks
1 parent bd24b80 commit 2309e50

10 files changed

+27
-18
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ before_script:
77
- npm install -g bower
88
- bower install --production
99
- bower install --force jquery#$JQUERY_VERSION
10+
- ./node_modules/.bin/grunt build
1011
- export DISPLAY=:99.0
1112
- sh -e /etc/init.d/xvfb start
1213
- sleep 5

src/callbacks.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,12 @@
77
* Copyright 2014-2016 Webcreate (Jeroen Fiege)
88
*/
99

10-
var IASCallbacks = function ($) {
10+
var IASCallbacks = function (aJquery) {
1111
this.list = [];
1212
this.fireStack = [];
1313
this.isFiring = false;
1414
this.isDisabled = false;
15+
this.Deferred = aJquery.Deferred;
1516

1617
/**
1718
* Calls all added callbacks
@@ -129,7 +130,7 @@ IASCallbacks.prototype = {
129130
* @returns {object|void}
130131
*/
131132
fireWith: function (context, args) {
132-
var deferred = $.Deferred();
133+
var deferred = this.Deferred();
133134

134135
if (this.isDisabled) {
135136
return deferred.reject();

src/extension/history.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ var IASHistoryExtension = function (options) {
1515
this.prevSelector = options.prev;
1616
this.prevUrl = null;
1717
this.listeners = {
18-
prev: new IASCallbacks()
18+
prev: new IASCallbacks(jQuery)
1919
};
2020

2121
/**

src/extension/paging.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ var IASPagingExtension = function() {
1414
this.lastPageNum = 1;
1515
this.enabled = true;
1616
this.listeners = {
17-
pageChange: new IASCallbacks()
17+
pageChange: new IASCallbacks(jQuery)
1818
};
1919

2020
/**

test/00-callbacks-test.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ describe("Callbacks", function () {
44
});
55

66
it("can add callback", function() {
7-
var callbacks = new IASCallbacks(),
7+
var callbacks = new IASCallbacks(jQuery),
88
spy1 = this.spy();
99

1010
expect(callbacks.has(spy1)).toBeFalse();
@@ -15,7 +15,7 @@ describe("Callbacks", function () {
1515
});
1616

1717
it("can remove callback", function() {
18-
var callbacks = new IASCallbacks(),
18+
var callbacks = new IASCallbacks(jQuery),
1919
spy1 = this.spy();
2020

2121
callbacks.add(spy1);
@@ -28,7 +28,7 @@ describe("Callbacks", function () {
2828
});
2929

3030
it("can fire callback", function() {
31-
var callbacks = new IASCallbacks(),
31+
var callbacks = new IASCallbacks(jQuery),
3232
spy1 = this.spy(),
3333
spy2 = this.spy();
3434

@@ -42,7 +42,7 @@ describe("Callbacks", function () {
4242
});
4343

4444
it("can be enabled/disabled", function() {
45-
var callbacks = new IASCallbacks(),
45+
var callbacks = new IASCallbacks(jQuery),
4646
spy1 = this.spy(),
4747
spy2 = this.spy();
4848

@@ -65,7 +65,7 @@ describe("Callbacks", function () {
6565
});
6666

6767
it("can add callback with priority", function() {
68-
var callbacks = new IASCallbacks(),
68+
var callbacks = new IASCallbacks(jQuery),
6969
lastedCalledSpy = null,
7070
spy1 = function() { lastedCalledSpy = "spy1"; },
7171
spy2 = function() { lastedCalledSpy = "spy2"; };

test/03-extensions-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ describe("IAS", function () {
6565
it("extension can add listeners", function() {
6666
var anExtension = function() {
6767
this.listeners = {
68-
test: new IASCallbacks()
68+
test: new IASCallbacks(jQuery)
6969
};
7070
};
7171

test/04-history-extension-test.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ describe("IAS", function () {
2323
prev: '.prev-posts a'
2424
}));
2525

26+
ias.initialize();
27+
2628
expect(ias.prev).toBeDefined();
2729
});
2830

test/04-trigger-extension-test.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ describe("IAS", function () {
2424
html: '<div class="ias-trigger extra-trigger-class">{text}</div>'
2525
}));
2626

27+
jQuery.ias().initialize();
28+
2729
expect($('.ias-trigger:visible').length).toEqual(0); // ensure it isn't already there
2830

2931
scrollDown().then(function() {

test/06-ajax-test.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,12 @@ describe("IAS", function () {
1515

1616
ias.extension(new IASSpinnerExtension());
1717
ias.extension(new IASNoneLeftExtension());
18+
19+
ias.initialize();
1820
});
1921

2022
after(function() {
21-
ias.destroy();
23+
jQuery.ias('destroy');
2224
});
2325

2426
it("should keep working when items container gets updated", function() {

test/buster.js

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,14 @@ config["My tests"] = {
1717
"bower_components/jquery/" + bower.jquery.main.replace(/^\.\//, ''),
1818
],
1919
sources: [
20-
"src/callbacks.js",
21-
"src/jquery-ias.js",
22-
"src/extension/paging.js",
23-
"src/extension/spinner.js",
24-
"src/extension/trigger.js",
25-
"src/extension/noneleft.js",
26-
"src/extension/history.js"
20+
"dist/jquery-ias.min.js",
21+
// "src/callbacks.js",
22+
// "src/jquery-ias.js",
23+
// "src/extension/paging.js",
24+
// "src/extension/spinner.js",
25+
// "src/extension/trigger.js",
26+
// "src/extension/noneleft.js",
27+
// "src/extension/history.js"
2728
],
2829
resources: [
2930
{ path: "/", file: "test/fixtures/page1.html" },

0 commit comments

Comments
 (0)