Skip to content

Commit 36e9529

Browse files
authored
Merge pull request #308 from fieg/timing-noneleft-event
Tweaked when noneLeft event is fired
2 parents 639e216 + 8e7bf3a commit 36e9529

File tree

2 files changed

+9
-16
lines changed

2 files changed

+9
-16
lines changed

src/jquery-ias.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -552,24 +552,24 @@
552552
var url = this.nextUrl,
553553
self = this;
554554

555-
this.pause();
556-
557555
if (!url) {
558-
this.fire('noneLeft', [this.getLastItem()]);
559-
this.listeners['noneLeft'].disable(); // disable it so it only fires once
560-
561-
self.resume();
562-
563556
return false;
564557
}
565558

559+
this.pause();
560+
566561
var promise = this.fire('next', [url]);
567562

568563
promise.done(function() {
569564
self.load(url, function(data, items) {
570565
self.render(items, function() {
571566
self.nextUrl = self.getNextUrl(data);
572567

568+
if (!self.nextUrl) {
569+
self.fire('noneLeft', [self.getLastItem()]);
570+
self.listeners['noneLeft'].disable(); // disable it so it only fires once
571+
}
572+
573573
self.resume();
574574
});
575575
});

test/02-listeners-test.js

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -179,16 +179,9 @@ describe("IAS", function () {
179179
// scroll to page 3
180180
scrollDown().then(function() {
181181
wait(1500).then(function() {
182-
expect(spy1).not.toHaveBeenCalled();
182+
expect(spy1).toHaveBeenCalledOnce();
183183

184-
// now on the final page, scroll down, and expect to have been called
185-
scrollDown().then(function() {
186-
wait(1500).then(function() {
187-
expect(spy1).toHaveBeenCalledOnce();
188-
189-
deferred.resolve();
190-
});
191-
});
184+
deferred.resolve();
192185
});
193186
});
194187
});

0 commit comments

Comments
 (0)