Don’t request duplicate prinicpal IDs from AzureAD

Signed-off-by: Markus Blaschke <[email protected]>

Author: mblaschke

metrics_azurerm_iam.go

@@ -139,28 +139,33 @@ func (m *MetricsCollectorAzureRmIam) collectRoleAssignments(ctx context.Context,
 
 	infoMetric := prometheusCommon.NewMetricsList()
 
-	principalIdList := []string{}
+	principalIdMap := map[string]string{}
 
 	for list.NotDone() {
 		val := list.Value()
+		principalId := *val.Properties.PrincipalID
 
 		infoLabels := prometheus.Labels{
 			"subscriptionID":   *subscription.SubscriptionID,
 			"roleAssignmentID": *val.ID,
 			"roleDefinitionID": extractRoleDefinitionIdFromAzureId(*val.Properties.RoleDefinitionID),
 			"resourceID":       *val.Properties.Scope,
 			"resourceGroup":    extractResourceGroupFromAzureId(*val.Properties.Scope),
-			"principalID":      *val.Properties.PrincipalID,
+			"principalID":      principalId,
 		}
 		infoMetric.AddInfo(infoLabels)
 
-		principalIdList = append(principalIdList, *val.Properties.PrincipalID)
+		principalIdMap[principalId] = principalId
 
 		if list.NextWithContext(ctx) != nil {
 			break
 		}
 	}
 
+	principalIdList := []string{}
+	for _, val := range principalIdMap {
+		principalIdList = append(principalIdList, val)
+	}
 	m.collectPrincipals(ctx, callback, subscription, principalIdList)
 
 	callback <- func() {
@@ -235,7 +240,6 @@ func (m *MetricsCollectorAzureRmIam) collectPrincipals(ctx context.Context, call
 		}
 	}
 
-
 	callback <- func() {
 		infoMetric.GaugeSet(m.prometheus.principal)
 	}