Skip to content

Commit 87e51ef

Browse files
committed
Disable azure_scheduledevent_request by default
Enable env METRICS_REQUESTSTATS=1 by default
1 parent a9eba8d commit 87e51ef

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ Normally no configuration is needed but can be customized using environment vari
2222
| `API_ERROR_THRESHOLD` | `0` (disabled) | API error threshold after which app will panic (`0` = dislabed) |
2323
| `SCRAPE_TIME` | `1m` (time.Duration) | Time between API calls |
2424
| `SERVER_BIND` | `:8080` | IP/Port binding |
25+
| `METRICS_REQUESTSTATS` | `empty` | Enable metric `azure_scheduledevent_request` |
2526

2627

2728
Metrics
@@ -31,7 +32,7 @@ Metrics
3132
|---------------------------------------------|---------------------------------------------------------------------------------------|
3233
| `azure_scheduledevent_document_incarnation` | Document incarnation number (version) |
3334
| `azure_scheduledevent_event` | Fetched events from API |
34-
| `azure_scheduledevent_request` | Request histogram (count and request duration) |
35+
| `azure_scheduledevent_request` | Request histogram (count and request duration; disabled by default) |
3536
| `azure_scheduledevent_request_error` | Counter for failed requests |
3637

3738

main.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ var opts struct {
3131
ApiUrl string `long:"api-url" env:"API_URL" description:"Azure ScheduledEvents API URL" default:"http://169.254.169.254/metadata/scheduledevents?api-version=2017-11-01"`
3232
ApiTimeout time.Duration `long:"api-timeout" env:"API_TIMEOUT" description:"Azure API timeout (seconds)" default:"30s"`
3333
ApiErrorThreshold int `long:"api-error-threshold" env:"API_ERROR_THRESHOLD" description:"Azure API error threshold (after which app will panic)" default:"0"`
34+
35+
// metrics
36+
MetricsRequestStats bool `long:"metrics-requeststats" env:"METRICS_REQUESTSTATS" description:"Enable request stats metrics"`
3437
}
3538

3639
func main() {

metrics.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,8 +181,10 @@ func fetchApiUrl() (*AzureScheduledEventResponse, error) {
181181
return nil, err
182182
}
183183

184-
duration := time.Now().Sub(startTime)
185-
scheduledEventRequest.With(prometheus.Labels{}).Observe(duration.Seconds())
184+
if opts.MetricsRequestStats {
185+
duration := time.Now().Sub(startTime)
186+
scheduledEventRequest.With(prometheus.Labels{}).Observe(duration.Seconds())
187+
}
186188

187189
return ret, nil
188190
}

0 commit comments

Comments
 (0)