fix: compilation fails if used the integrity option with the publicPath as an external URL

Author: webdiscus

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 4.15.3 (2025-01-27)
+
+- fix: compilation fails if used the integrity option with the publicPath as an external URL
+- fix: improve error messages inc. error stack if async processes fail
+
 ## 4.15.2 (2025-01-22)
 
 - fix: unpredictably Webpack compilation fails after a random number of runs, #143

package.json

@@ -1,6 +1,6 @@
 {
   "name": "html-bundler-webpack-plugin",
-  "version": "4.15.2",
+  "version": "4.15.3",
   "description": "Generates complete single-page or multi-page website from source assets. Build-in support for Markdown, Eta, EJS, Handlebars, Nunjucks, Pug. Alternative to html-webpack-plugin.",
   "keywords": [
     "html",

src/Plugin/AssetCompiler.js

@@ -1734,7 +1734,10 @@ class AssetCompiler {
         // }
 
         if (this.exceptions.size > 0) {
-          const messages = Array.from(this.exceptions).join('\n\n');
+          const messages = Array.from(this.exceptions)
+            .map((error) => (error.stack ? error.stack : error.toString()))
+            .reduce((previousValue, currentValue) => previousValue + currentValue, '');
+
           this.exceptions.clear();
           throw new Error(messages);
         }

src/Plugin/Collection.js

@@ -992,10 +992,14 @@ class Collection {
               if (hasIntegrity && !inline) {
                 // path to asset relative by output.path
                 let pathname = asset.assetFile;
+
                 if (this.pluginOption.isAutoPublicPath()) {
                   pathname = path.join(entryDirname, pathname);
                 } else if (this.pluginOption.isRootPublicPath()) {
                   pathname = pathname.slice(1);
+                } else if (this.pluginOption.isUrlPublicPath()) {
+                  let publicPath = this.pluginOption.getPublicPath();
+                  pathname = pathname.replace(publicPath, '');
                 }
 
                 const assetContent = compilation.assets[pathname].source();

src/Plugin/Option.js

@@ -320,15 +320,15 @@ class Option {
     }
 
     this.autoPublicPath = false;
-    this.isUrlPublicPath = false;
+    this.urlPublicPath = false;
     this.rootPublicPath = false;
     this.isRelativePublicPath = false;
     this.webpackPublicPath = publicPath;
 
     if (publicPath === 'auto') {
       this.autoPublicPath = true;
     } else if (/^(\/\/|https?:\/\/)/i.test(publicPath)) {
-      this.isUrlPublicPath = true;
+      this.urlPublicPath = true;
     } else if (!publicPath.startsWith('/')) {
       this.isRelativePublicPath = true;
     } else if (publicPath.startsWith('/')) {
@@ -508,6 +508,10 @@ class Option {
     return this.rootPublicPath === true;
   }
 
+  isUrlPublicPath() {
+    return this.urlPublicPath === true;
+  }
+
   hasPostprocess() {
     return this.#process.has('postprocess');
   }
@@ -695,7 +699,7 @@ class Option {
       return isWin ? pathToPosix(outputFilename) : outputFilename;
     }
 
-    if (this.isUrlPublicPath) {
+    if (this.isUrlPublicPath()) {
       const url = new URL(assetFile, this.webpackPublicPath);
       return url.href;
     }

test/cases/integrity-publicPath-url/expected/assets/css/style.bundle.css

@@ -0,0 +1,3 @@
+h1 {
+  color: red;
+}

test/cases/integrity-publicPath-url/expected/assets/css/vendor.bundle.css

@@ -0,0 +1,3 @@
+h2 {
+  color: green;
+}

test/cases/integrity-publicPath-url/expected/assets/img/image.697ef306.png

@@ -0,0 +1 @@
+console.log(">> main");

test/cases/integrity-publicPath-url/expected/assets/js/main.bundle.js

@@ -0,0 +1 @@
+console.log(">> ignore integrity");