Ensure params, returns, typeParameters, extends, implements are not undefined (#184)

Ensure params, returns, typeParameters, extends, implements are not undefined

Author: ShukantPal

language/language-parser/rollup.config.mjs

@@ -5,7 +5,7 @@ import {fileURLToPath} from "url";
 export default await Promise.all([
   configureRollup({
     packageDirectory: path.dirname(fileURLToPath(import.meta.url)),
-    minify: true,
+    minify: false,
   }),
   configureRollup({
     packageDirectory: path.dirname(fileURLToPath(import.meta.url)),

language/language-parser/src/transformer/merge-returns.js

@@ -8,9 +8,11 @@ export default function mergeReturns(docReturns: Return[], metaReturns: Return[]
     return docReturns || metaReturns;
   }
 
-  // ASSUMPTION: docReturns & metaReturns have atleast one Return
-
-  docReturns[0].dataType = docReturns[0].dataType || metaReturns[0].dataType;
+  if (docReturns[0]) {
+    docReturns[0].dataType = docReturns[0].dataType || metaReturns[0].dataType;
+  } else {
+    docReturns[0] = metaReturns[0];
+  }
 
   return docReturns;
 }

language/language-parser/src/transformer/symbol-to-doc.js

@@ -295,9 +295,9 @@ export default function symbolToDoc(symbol: Symbol): ?Doc {
 
 // Infer everything we can from the metadata
 function infer(doc: any, meta: SymbolSignature) {
-  doc.params = mergeParams(doc.params, meta.params);
-  doc.returns = mergeReturns(doc.returns, meta.returns);
-  doc.extends = doc.extends || meta.extends;
-  doc.implements = doc.implements || meta.implements;
-  doc.typeParameters = doc.typeParameters || meta.typeParameters;
+  doc.params = mergeParams(doc.params ?? [], meta.params);
+  doc.returns = mergeReturns(doc.returns ?? [], meta.returns);
+  doc.extends = doc.extends || meta.extends || [];
+  doc.implements = doc.implements || meta.implements || [];
+  doc.typeParameters = doc.typeParameters || meta.typeParameters || [];
 }

language/language-parser/test/parse-ts.js

@@ -313,4 +313,27 @@ describe("@webdoc/parser.parse (Typescript)", function() {
     expect(parentClass.members.filter(div).length).to.equal(1);
     expect(childClass.members.filter(div)[0].overrides).to.not.equal(undefined);
   });
+
+  it.only("should cast property to @method properly", async () => {
+    await parse([{
+      content: `
+        /** DO */
+        class DisplayObject {
+          public displayObjectUpdateTransform: () => void;
+        }
+        
+        /**
+         * Here
+         *
+         * @method DisplayObject#displayObjectUpdateTransform
+         */
+        DisplayObject.prototype.displayObjectUpdateTransform =
+          DisplayObject.prototype.updateTransform;
+          
+        /** Container */
+        class Container extends DisplayObject {}
+      `,
+      path: "*.ts",
+    }]);
+  });
 });