Fix: Don't pass undefined identifier for array pattern varargs (#152)

* Fix: Don't pass undefined identifier for array pattern varargs

* fix test

Author: ShukantPal

.idea/webdoc.iml

@@ -216,8 +216,10 @@ export function extractParams(
         optional: paramNode.optional || false,
       };
     } else if (isRestElement(paramNode)) {
+      const argument = paramNode.argument;
+
       param = {
-        identifier: paramNode.argument.name,
+        identifier: isIdentifier(argument) ? argument.name : "rest_args",
         optional: paramNode.optional || false,
         variadic: true,
       };

packages/webdoc-parser/src/symbols-babel/extract-metadata.js

@@ -181,6 +181,32 @@ describe("@webdoc/parser.LanguageIntegration{@lang ts}", function() {
     expect(symtree.members[0].members.length).to.equal(1);
   });
 
+  // it("should work with spread object parameters", function() {
+  //   const symbolTree = buildSymbolTree(`
+  //     /** Build */
+  //     class Factory {
+  //       /** Build with options. */
+  //       build({ arg0, arg1, arg2 }: Opts) { }
+  //     }
+  //   `);
+  //   const build = symbolTree.members[0].members[0];
+  //
+  //   expect(build.meta.params.length).to.equal(4);// implicit param!
+  // });
+
+  it("should work with spread tuple parameters", function() {
+    const symbolTree = buildSymbolTree(`
+       /** Figure it out. */
+       function dynamic_call(...[a0, a1]: [string, number] | [number, string]) {
+       }
+    `);
+    const dynamicCall = symbolTree.members[0];
+
+    expect(dynamicCall.meta.params.length).to.equal(1);
+    expect(dynamicCall.meta.params[0].identifier).to.not.equal(undefined);
+    expect(dynamicCall.meta.params[0].dataType[0]).to.equal("[string, number] | [number, string]");
+  });
+
   it("should parse type parameters", function() {
     const symbolTree = buildSymbolTree(`
       class Builder {
@@ -195,7 +221,7 @@ describe("@webdoc/parser.LanguageIntegration{@lang ts}", function() {
     expect(symbolTree.members[0].members[1].meta.dataType[0]).to.equal("Map<K, V>");
   });
 
-  it("should parse parameter types", function() {
+  it("should parse parameter types with default values", function() {
     const symbolTree = buildSymbolTree(`
       function mark(what: object | string = 'test') {
       }

packages/webdoc-parser/test/lang-ts.js

@@ -154,6 +154,27 @@ describe("@webdoc/parser.parse (Typescript)", function() {
     expect(lengthProperty.dataType[0]).to.equal("number");
   });
 
+  it("should work with arrow function properties", async function() {
+    const documentTree = await parse([{
+      content: `
+        class Factory {
+          /**
+           * Build the object.
+           * @param args - Args.
+           */
+          create = (args: Opts) => undefined
+        }
+      `,
+      path: "*.ts",
+      package: createPackageDoc(),
+    }]);
+    const createMethod = findDoc("Factory.create", documentTree);
+
+    // expect(createMethod.type).to.equal("MethodDoc");
+    expect(createMethod.params.length).to.equal(1);
+    // expect(createMethod.params[0].dataType[0]).to.equal("Opts");
+  });
+
   it("should properly inherit all method overloads", async function() {
     const documentTree = await parse([{
       content: `