Skip to content

Commit b20b260

Browse files
committed
Fix type check, fail on failure in CI
1 parent ec83cfb commit b20b260

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

azure-pipelines.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,11 @@ steps:
3636
rush flow
3737
displayName: "Type check"
3838
workingDirectory: webdoc
39-
continueOnError: true
4039

4140
- script: |
4241
rush lint
4342
displayName: "Lint"
4443
workingDirectory: webdoc
45-
continueOnError: true
4644

4745
- script: |
4846
rush unit-test

packages/webdoc-parser/src/symbols-babel/extract-symbol.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,7 @@ function resolveRootObject(expression: MemberExpression): string {
406406

407407
// Used to get default value
408408
// TODO: Resolve a lot more expressions
409-
function resolveExpression(expression: BabelNodeExpression): string | undefined {
409+
function resolveExpression(expression: BabelNodeExpression): string | void {
410410
if (isLiteral(expression)) {
411411
if (isStringLiteral(expression)) {
412412
return `"${expression.value}"`;
@@ -415,7 +415,7 @@ function resolveExpression(expression: BabelNodeExpression): string | undefined
415415
}
416416
}
417417
if (isUnaryExpression(expression)) {
418-
return `-${resolveExpression(expression.argument)}`;
418+
return `-${resolveExpression(expression.argument) || ""}`;
419419
}
420420
}
421421

0 commit comments

Comments
 (0)