Merge pull request #148 from webdoc-labs/fix/assignment-pattern-type-infererence

Fix: Type inference for parameters with assignment pattern

Author: ShukantPal

packages/webdoc-parser/src/symbols-babel/extract-metadata.js

@@ -8,6 +8,7 @@ import {
   type BabelNodeQualifiedName,
   type BabelNodeTSTypeAnnotation,
   type BabelNodeTypeAnnotation,
+  type BabelTSTypeAnnotation,
   type ClassDeclaration,
   type ClassExpression,
   type ClassMethod,
@@ -196,6 +197,7 @@ export function extractParams(
   for (let i = 0; i < nodeParams.length; i++) {
     let paramNode = nodeParams[i];
     let param: ?$Shape<Param>;
+    let paramTypeAnnotation: ?BabelTSTypeAnnotation;
 
     if (isTSParameterProperty(paramNode)) {
       paramNode = paramNode.parameter;
@@ -216,6 +218,7 @@ export function extractParams(
     } else if (isAssignmentPattern(paramNode)) {
       const extraRaw = paramNode.right.extra && paramNode.right.extra.raw;
 
+      paramTypeAnnotation = paramNode.left.typeAnnotation;
       param = {
         identifier: paramNode.left.name,
         optional: paramNode.optional || false,
@@ -233,9 +236,12 @@ export function extractParams(
       console.error("Parameter node couldn't be parsed");
     }
 
-    if (param && paramNode.typeAnnotation) {
+    if (param && paramTypeAnnotation) {
+      param.dataType = extractType(paramTypeAnnotation);
+    } else if (param && paramNode.typeAnnotation) {
       param.dataType = extractType(paramNode.typeAnnotation);
     }
+
     if (param) {
       params.push(param);
     }

packages/webdoc-parser/test/lang-ts.js

@@ -194,4 +194,13 @@ describe("@webdoc/parser.LanguageIntegration{@lang ts}", function() {
     expect(symbolTree.members[0].members[0].meta.dataType[0]).to.equal("Array<T>");
     expect(symbolTree.members[0].members[1].meta.dataType[0]).to.equal("Map<K, V>");
   });
+
+  it("should parse parameter types", function() {
+    const symbolTree = buildSymbolTree(`
+      function mark(what: object | string = 'test') {
+      }
+    `);
+
+    expect(symbolTree.members[0].meta.params[0].dataType[0]).to.equal("object | string");
+  });
 });