Skip to content

Commit 6b2e955

Browse files
committed
Slider UI update
1 parent cc1f427 commit 6b2e955

File tree

3 files changed

+7
-10
lines changed

3 files changed

+7
-10
lines changed

packages/app/src/components/browser/snapshot.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,6 @@ export class DevtoolsBrowser extends Element {
8888
return
8989
}
9090

91-
this.section.style.width = 'auto'
92-
this.section.style.height = 'auto'
93-
9491
this.iframe.removeAttribute('style')
9592
const viewportWidth = metadata.viewport.width
9693
const viewportHeight = metadata.viewport.height
@@ -302,7 +299,7 @@ export class DevtoolsBrowser extends Element {
302299
}
303300

304301
return html`
305-
<section class="w-full bg-sideBarBackground rounded-t-md shadow-md">
302+
<section class="w-full h-full bg-sideBarBackground rounded-t-md shadow-md">
306303
<header class="flex block mx-2">
307304
<div class="frame-dot bg-notificationsErrorIconForeground"></div>
308305
<div class="frame-dot bg-notificationsWarningIconForeground"></div>
@@ -313,7 +310,7 @@ export class DevtoolsBrowser extends Element {
313310
</div>
314311
</header>
315312
${this.mutations && this.mutations.length
316-
? html`<iframe class="origin-top-left"></iframe>`
313+
? html`<iframe class="origin-top-left h-full w-full"></iframe>`
317314
: html`<wdio-devtools-placeholder style="height: 100%"></wdio-devtools-placeholder>`
318315
}
319316
</section>

packages/app/src/components/workbench.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export class DevtoolsWorkbench extends Element {
8585
horizontalResizerWindow?: HTMLElement
8686

8787
render() {
88-
const heightWorkbench = this.#toolbarCollapsed ? '' : 'h-[70%]'
88+
const heightWorkbench = this.#toolbarCollapsed ? 'h-full' : 'h-[70%]'
8989
const styleWorkbench = this.#toolbarCollapsed ? '' : this.#dragVertical.getPosition()
9090
return html`
9191
<section data-horizontal-resizer-window class="flex w-full ${heightWorkbench} flex-1" style="${styleWorkbench}">
@@ -117,7 +117,7 @@ export class DevtoolsWorkbench extends Element {
117117
<section class="basis-auto text-gray-500 flex items-center justify-center flex-grow">
118118
<wdio-devtools-browser></wdio-devtools-browser>
119119
</section>
120-
${!this.#workbenchSidebarCollapsed ? this.#dragHorizontal.getSlider() : nothing}
120+
${this.#dragHorizontal.getSlider(this.#workbenchSidebarCollapsed ? 'hidden' : this.#toolbarCollapsed ? 'h-full' : 'h-[70%]')}
121121
</section>
122122
<wdio-devtools-tabs cacheId="activeWorkbenchTab" class="border-t-[1px] border-t-panelBorder ${this.#toolbarCollapsed ? 'hidden' : ''}">
123123
<wdio-devtools-tab label="Source">
@@ -148,7 +148,7 @@ export class DevtoolsWorkbench extends Element {
148148
`
149149
: nothing
150150
}
151-
${!this.#toolbarCollapsed ? this.#dragVertical.getSlider() : nothing}
151+
${this.#dragVertical.getSlider(this.#toolbarCollapsed ? 'hidden' : '')}
152152
`
153153
}
154154
}

packages/app/src/utils/DragController.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ export class DragController implements ReactiveController {
215215
? 'top'
216216
: ''
217217
className += this.#options.direction === Direction.horizontal
218-
? ' cursor-col-resize left-0 h-full w-[10px]'
218+
? ' cursor-col-resize left-0 w-[10px]'
219219
: this.#options.direction === Direction.vertical
220220
? ' cursor-row-resize top-0 w-full h-[10px]'
221221
: ''
@@ -225,7 +225,7 @@ export class DragController implements ReactiveController {
225225
data-draggable-id=${this.#id}
226226
data-dragging=${this.#state}
227227
style=${styleMap({ [anchor]: `${this.#getPosition() - 3}px` })}
228-
class="absolute ${className}"></button>
228+
class="absolute z-10 ${className}"></button>
229229
`
230230
}
231231

0 commit comments

Comments
 (0)