Eslint cleanup

Author: vishnuv688

.eslintignore

@@ -5,6 +5,9 @@ const importPlugin = require('eslint-plugin-import')
 const unicorn = require('eslint-plugin-unicorn')
 
 module.exports = [
+  {
+    ignores: ['node_modules/**', '**/dist/**'],
+  },
   // Base JS config
   {
     ...js.configs.recommended,
@@ -39,9 +42,7 @@ module.exports = [
       'require-atomic-updates': 0,
       'linebreak-style': ['error', 'unix'],
       'import/extensions': ['error', 'ignorePackages'],
-      'no-restricted-syntax': ['error', 'IfStatement > ExpressionStatement > AssignmentExpression'],
-      '@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
-
+      'no-restricted-syntax': ['error', 'IfStatement > ExpressionStatement > AssignmentExpression']
     },
   },
 
@@ -55,15 +56,15 @@ module.exports = [
       parser: tsParser,
     },
     rules: {
-      'no-unused-vars': 'off',
-      '@typescript-eslint/no-unused-vars': 'error',
+      '@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
       '@typescript-eslint/consistent-type-imports': 'error',
+      'no-unused-vars': 'off',
       'no-undef': 'off',
       'no-redeclare': 'off',
     },
   },
 
-  // Test files
+  // TypeScript test files
   {
     files: ['**/*.test.ts'],
     rules: {

eslint.config.cjs

@@ -75,7 +75,7 @@ export class ExplorerTestEntry extends CollapseableEntry {
   }
 
   #viewSource() {
-    if (!this.callSource) return
+    if (!this.callSource) {return}
     window.dispatchEvent(new CustomEvent('app-source-highlight', {
       detail: this.callSource
     }))

packages/app/src/components/sidebar/test-suite.ts

@@ -87,9 +87,9 @@ export class DevtoolsList extends Element {
   render () {
     const isArrayList = Array.isArray(this.list)
 
-    if (this.list == null) return null
-    if (isArrayList && (this.list as unknown[]).length === 0) return null
-    if (!isArrayList && Object.keys(this.list as Record<string, unknown>).length === 0) return null
+    if (this.list === null) {return null}
+    if (isArrayList && (this.list as unknown[]).length === 0) {return null}
+    if (!isArrayList && Object.keys(this.list as Record<string, unknown>).length === 0) {return null}
 
     const entries: unknown[] | [string, unknown][] = isArrayList
       ? (this.list as unknown[])

packages/app/src/components/workbench/list.ts

@@ -41,12 +41,12 @@ export class DevtoolsSource extends Element {
   }
 
   #renderEditor (filePath: string, highlightLine?: number) {
-    if (!this.sources) return
+    if (!this.sources) {return}
     const source = this.sources[filePath]
-    if (!source) return
+    if (!source) {return}
 
     const container = this.shadowRoot?.querySelector('section') || this.shadowRoot?.querySelector('.cm-editor')
-    if (!container) return
+    if (!container) {return}
 
     const opts: EditorViewConfig = {
       root: this.shadowRoot!,

packages/app/src/components/workbench/source.ts

@@ -141,8 +141,7 @@ export class DataManagerController implements ReactiveController {
           ...this.consoleLogsContextProvider.value,
           ...data as string[]
         ])
-      }
-      else if (scope === 'sources') {
+      } else if (scope === 'sources') {
         const merged = {
           ...(this.sourcesContextProvider.value || {}),
           ...(data as Record<string, string>)

packages/app/src/controller/DataManager.ts

@@ -108,11 +108,11 @@ export class DragController implements ReactiveController {
   #setPosition(x: number, y: number) {
     if (this.#options.direction === Direction.horizontal) {
       let nx = Math.max(x, this.#options.minPosition || 0)
-      if (this.#options.maxPosition !== undefined) nx = Math.min(nx, this.#options.maxPosition)
+      if (this.#options.maxPosition !== undefined) {nx = Math.min(nx, this.#options.maxPosition)}
       this.#x = nx
     } else {
       let ny = Math.max(y, this.#options.minPosition || 0)
-      if (this.#options.maxPosition !== undefined) ny = Math.min(ny, this.#options.maxPosition)
+      if (this.#options.maxPosition !== undefined) {ny = Math.min(ny, this.#options.maxPosition)}
       this.#y = ny
     }
   }
@@ -236,7 +236,7 @@ export class DragController implements ReactiveController {
 
   async #maybeReinit() {
     const draggableEl = await this.#getDraggableEl()
-    if (!draggableEl) return
+    if (!draggableEl) {return}
     // if slider was removed (collapsed) and re-added, re-init pointer tracker
     if (this.#draggableEl !== draggableEl) {
       this.#draggableEl = draggableEl as HTMLElement

packages/app/src/utils/DragController.ts

@@ -6,7 +6,7 @@ export async function getDevtoolsApp () {
   try {
     const appPkg = await resolve('@wdio/devtools-app', import.meta.url)
     return path.resolve(url.fileURLToPath(appPkg), '..', '..', 'dist')
-  } catch (err) {
+  } catch {
     throw new Error('Couldn\'t find @wdio/devtools-app package, do you have it installed?')
   }
 }

packages/backend/src/utils.ts

@@ -78,7 +78,7 @@ export default class DevToolsHookService implements Services.ServiceInstance {
     #commandStack: string[] = []
 
     // This is used to capture the last command signature to avoid duplicate captures
-    #lastCommandSig: string | null = null;
+    #lastCommandSig: string | null = null
 
     /**
      * allows to define the type of data being captured to hint the
@@ -183,18 +183,18 @@ export default class DevToolsHookService implements Services.ServiceInstance {
               command,
               args,
               src: source.getFileName() + ':' + source.getLineNumber()
-            });
+            })
 
             if (this.#lastCommandSig !== cmdSig) {
-                this.#commandStack.push(command);
-                this.#lastCommandSig = cmdSig;
+                this.#commandStack.push(command)
+                this.#lastCommandSig = cmdSig
             }
         }
     }
 
     afterCommand(command: keyof WebDriverCommands, args: any[], result: any, error?: Error) {
         // Skip bookkeeping for internal injection calls
-        if (this.#injecting) return
+        if (this.#injecting) {return}
 
         /* Ensure that the command is captured only if it matches the last command in the stack.
         * This prevents capturing commands that are not top-level user commands.
@@ -243,8 +243,8 @@ export default class DevToolsHookService implements Services.ServiceInstance {
     }
 
     async #ensureInjected(reason: string) {
-        if (!this.#browser) return
-        if (this.#injecting) return
+        if (!this.#browser) {return}
+        if (this.#injecting) {return}
         try {
             this.#injecting = true
             // Cheap marker check (no heavy stack work)

packages/service/src/index.ts

@@ -45,20 +45,20 @@ export class DevToolsAppLauncher {
   async onComplete () {
     if (this.#browser) {
       logger.setLevel('devtools', 'warn')
-      log.info('Please close the browser window to finish...');
+      log.info('Please close the browser window to finish...')
       while (true) {
         try {
-          await this.#browser.getTitle();
-          await new Promise(res => setTimeout(res, 1000));
-        } catch (e) {
-          log.info('Browser window closed, stopping DevTools app');
-          break;
+          await this.#browser.getTitle()
+          await new Promise(res => setTimeout(res, 1000))
+        } catch {
+          log.info('Browser window closed, stopping DevTools app')
+          break
         }
       }
       try {
-        await this.#browser.deleteSession();
+        await this.#browser.deleteSession()
       } catch (err: any) {
-        log.warn('Session already closed or could not be deleted:', err.message);
+        log.warn('Session already closed or could not be deleted:', err.message)
       }
     }
   }