Code review

Author: dprevost-LMI

test/matchers/browser/toHaveClipboardText.test.ts

@@ -11,17 +11,17 @@ const afterAssertion = vi.fn()
 test('toHaveClipboardText', async () => {
     browser.execute = vi.fn().mockResolvedValue('some clipboard text')
 
-    const result = await toHaveClipboardText(browser, 'some ClipBoard text', { ignoreCase: true, beforeAssertion, afterAssertion, wait: 1 })
+    const result = await toHaveClipboardText(browser, 'some ClipBoard text', { ignoreCase: true, beforeAssertion, afterAssertion })
     expect(result.pass).toBe(true)
     expect(beforeAssertion).toBeCalledWith({
         matcherName: 'toHaveClipboardText',
         expectedValue: 'some ClipBoard text',
-        options: { ignoreCase: true, beforeAssertion, afterAssertion, wait: 1 }
+        options: { ignoreCase: true, beforeAssertion, afterAssertion }
     })
     expect(afterAssertion).toBeCalledWith({
         matcherName: 'toHaveClipboardText',
         expectedValue: 'some ClipBoard text',
-        options: { ignoreCase: true, beforeAssertion, afterAssertion, wait: 1 },
+        options: { ignoreCase: true, beforeAssertion, afterAssertion },
         result
     })
 })

test/matchers/element/toHaveText.test.ts

@@ -505,8 +505,8 @@ Received: undefined`)
             { actual: 5, selectorName: '5' },
             { actual: 'test', selectorName: 'test' },
             { actual: Promise.resolve(true), selectorName: 'true' },
-            { actual: {}, selectorName: '[object Object]' },
-            { actual: ['1', '2'], selectorName: '1,2' },
+            { actual: {}, selectorName: '{}' },
+            { actual: ['1', '2'], selectorName: '["1","2"]' },
         ])('should have pass false with proper error message when actual is unsupported type of $actual', async ({ actual, selectorName }) => {
             const result = await thisContext.toHaveText(actual as any, 'webdriverio')
 

vitest.config.ts

@@ -28,10 +28,14 @@ export default defineConfig({
                 'types-checks-filter-out-node_modules.js',
             ],
             thresholds: {
-                lines: 88.3,
-                functions: 85.9,
-                statements: 88.2,
-                branches: 79.6,
+                lines: 88.7,
+                functions: 87.2,
+                statements: 88.8,
+                branches: 84.4,
+                // lines: 100,
+                // functions: 100,
+                // statements: 100,
+                // branches: 100,
             }
         }
     }