Convert PHPUnit annotations to attributes

Author: mpdude

tests/NotModified/Attribute/ReplaceWithNotModifiedResponseTest.php

@@ -10,6 +10,9 @@
 namespace Webfactory\HttpCacheBundle\Tests\NotModified\Attribute;
 
 use DateTime;
+use PHPUnit\Framework\Attributes\DoesNotPerformAssertions;
+use PHPUnit\Framework\Attributes\Group;
+use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 use RuntimeException;
@@ -23,30 +26,23 @@
  */
 final class ReplaceWithNotModifiedResponseTest extends TestCase
 {
-    /**
-     * @test
-     */
+    #[Test]
     public function lastModifiedDescriptionsCannotBeEmpty()
     {
         $this->expectException(RuntimeException::class);
         $attribute = new ReplaceWithNotModifiedResponse([]);
         $attribute->determineLastModified(new Request());
     }
 
-    /**
-     * @test
-     *
-     * @doesNotPerformAssertions
-     */
+    #[Test]
+    #[DoesNotPerformAssertions]
     public function stringAsSimpleLastModifiedDescription()
     {
         $attribute = new ReplaceWithNotModifiedResponse([MyLastModifedDeterminator::class]);
         $attribute->determineLastModified(new Request());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function serviceNameAsLastModifiedDescription()
     {
         /** @var ContainerInterface|MockObject $container */
@@ -62,32 +58,24 @@ public function serviceNameAsLastModifiedDescription()
         $attribute->determineLastModified(new Request());
     }
 
-    /**
-     * @test
-     *
-     * @doesNotPerformAssertions
-     */
+    #[Test]
+    #[DoesNotPerformAssertions]
     public function arrayAslastModifiedDeterminatorDescriptionWithConstructorArguments()
     {
         $attribute = new ReplaceWithNotModifiedResponse([[MyLastModifedDeterminator::class => new DateTime('2000-01-01')]]);
         $attribute->determineLastModified(new Request());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function lastModifiedDeterminatorsHaveToImplementInterface()
     {
         $this->expectException(RuntimeException::class);
         $attribute = new ReplaceWithNotModifiedResponse([FakeLastModifiedDeterminatorWithoutInterface::class]);
         $attribute->determineLastModified(new Request());
     }
 
-    /**
-     * @test
-     *
-     * @group time-sensitive
-     */
+    #[Group('time-sensitive')]
+    #[Test]
     public function determineLastModifiedDeterminesLastModifiedOfOneDeterminator()
     {
         $attribute = new ReplaceWithNotModifiedResponse([MyLastModifedDeterminator::class]);
@@ -97,9 +85,7 @@ public function determineLastModifiedDeterminesLastModifiedOfOneDeterminator()
         self::assertEquals(DateTime::createFromFormat('U', time()), $lastModified);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function determineLastModifiedDeterminesLastModifiedOfMultipleDeterminators()
     {
         $attribute = new ReplaceWithNotModifiedResponse([

tests/NotModified/EventListenerTest.php

@@ -12,6 +12,8 @@
 use Closure;
 use DateTime;
 use Error;
+use PHPUnit\Framework\Attributes\Group;
+use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\DependencyInjection\ContainerInterface;
@@ -27,9 +29,8 @@
 
 /**
  * Tests for the EventListener.
- *
- * @group time-sensitive
  */
+#[Group('time-sensitive')]
 final class EventListenerTest extends TestCase
 {
     /**
@@ -53,31 +54,31 @@ protected function setUp(): void
         $this->eventListener = new EventListener($this->container);
     }
 
-    /** @test */
+    #[Test]
     public function onKernelControllerDoesNoHarmForMissingAnnotation(): void
     {
         $this->exerciseOnKernelController([DummyController::class, 'plainAction']);
 
         $this->assertRegularControllerResponse();
     }
 
-    /** @test */
+    #[Test]
     public function onKernelControllerDoesNoHarmForNoDeterminedLastModified(): void
     {
         $this->exerciseOnKernelController([DummyController::class, 'abstainingLastModifiedAction']);
 
         $this->assertRegularControllerResponse();
     }
 
-    /** @test */
+    #[Test]
     public function onKernelControllerDoesNoHarmIfNotModifiedSinceHeaderIsNotInRequest(): void
     {
         $this->exerciseOnKernelController([DummyController::class, 'oneDayAgoModifiedLastModifiedAction']);
 
         $this->assertRegularControllerResponse();
     }
 
-    /** @test */
+    #[Test]
     public function onKernelControllerSkipsToModifiedResponseIfLastModifiedIsSmallerThanIfNotModifiedSinceHeader(): void
     {
         $this->request->headers->set('If-Modified-Since', '-1 hour');
@@ -87,7 +88,7 @@ public function onKernelControllerSkipsToModifiedResponseIfLastModifiedIsSmaller
         $this->assertNotModifiedResponse();
     }
 
-    /** @test */
+    #[Test]
     public function onKernelControllerAlwaysRunsControllerInKernelDebugMode(): void
     {
         $this->eventListener = new EventListener($this->container, true);
@@ -98,7 +99,7 @@ public function onKernelControllerAlwaysRunsControllerInKernelDebugMode(): void
         $this->assertRegularControllerResponse();
     }
 
-    /** @test */
+    #[Test]
     public function onKernelControllerSkipsToNotModifiedResponseIfLastModifiedIsEqualToIfNotModifiedSinceHeader(): void
     {
         $this->request->headers->set('If-Modified-Since', '2000-01-01');
@@ -108,7 +109,7 @@ public function onKernelControllerSkipsToNotModifiedResponseIfLastModifiedIsEqua
         $this->assertNotModifiedResponse();
     }
 
-    /** @test */
+    #[Test]
     public function onKernelControllerDoesNotReplaceDeterminedControllerIfLastModifiedIsGreaterThanIfNotModifiedSinceHeader(): void
     {
         $this->request->headers->set('If-Modified-Since', '-2 day');
@@ -118,9 +119,7 @@ public function onKernelControllerDoesNotReplaceDeterminedControllerIfLastModifi
         $this->assertRegularControllerResponse();
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function onKernelResponseSetsLastModifiedHeaderToResponseIfAvailable(): void
     {
         $this->exerciseOnKernelController([DummyController::class, 'oneDayAgoModifiedLastModifiedAction']);
@@ -131,7 +130,7 @@ public function onKernelResponseSetsLastModifiedHeaderToResponseIfAvailable(): v
         self::assertEquals(DateTime::createFromFormat('U', time() - 86400), $this->response->getLastModified());
     }
 
-    /** @test */
+    #[Test]
     public function onKernelResponseDoesNotSetLastModifiedHeaderToResponseIfNotAvailable(): void
     {
         $this->exerciseOnKernelController([DummyController::class, 'abstainingLastModifiedAction']);
@@ -142,7 +141,7 @@ public function onKernelResponseDoesNotSetLastModifiedHeaderToResponseIfNotAvail
         self::assertNull($this->response->getLastModified());
     }
 
-    /** @test */
+    #[Test]
     public function eventListenerDifferentiatesBetweenMultipleRequests(): void
     {
         $this->exerciseOnKernelController([DummyController::class, 'oneDayAgoModifiedLastModifiedAction']);
@@ -160,7 +159,7 @@ public function eventListenerDifferentiatesBetweenMultipleRequests(): void
         self::assertNull($anotherResponse->getLastModified());
     }
 
-    /** @test */
+    #[Test]
     public function onKernelControllerSearchesEventInsteadOfControllerForAttribute(): void
     {
         // setup an event that should lead to a NotModified response
@@ -186,7 +185,7 @@ function () {
         self::assertNotModifiedResponse();
     }
 
-    /** @test */
+    #[Test]
     public function onKernelControllerSavesOriginalControllerAttributesWhenReplacingTheController(): void
     {
         $this->request->headers->set('If-Modified-Since', '-1 hour');
@@ -196,7 +195,7 @@ public function onKernelControllerSavesOriginalControllerAttributesWhenReplacing
         self::assertNotEmpty($this->filterControllerEvent->getAttributes());
     }
 
-    /** @test */
+    #[Test]
     public function onKernelControllerThrowsExceptionIfAttributeIsFoundMoreThanOnce(): void
     {
         self::expectException(Error::class);