Get ImportProjectTaskTest closer to real life

Until now, the test tests almost nothing:

It doesn't verify results and acts rather as a smoke test. But it also mocks away all the dependencies, and only tests the few lines of the `import` method against empty mocks rather than real services.

This commit shows that it is possible to test way more real-life interaction with even less code. Only PackageVersionFetcher and VcsDriverFactory are mocked now, to prevent real network requests.

For more test result verification, we should use a tool like Foundry.

Author: janopae

src/AppBundle/Tests/ProjectImport/ImportProjectTaskTest.php

@@ -10,23 +10,30 @@
 use Doctrine\Common\Collections\ArrayCollection;
 use Doctrine\ORM\EntityManagerInterface;
 use PHPUnit\Framework\MockObject\MockObject;
-use PHPUnit\Framework\TestCase;
 use Psr\Log\NullLogger;
+use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 
-class ImportProjectTaskTest extends TestCase
+class ImportProjectTaskTest extends KernelTestCase
 {
     /**
      * @var ImportProjectTask
      */
     private $importProjectTask;
 
+    private PackageVersionFetcher&MockObject $packageVersionFetcher;
+    private VcsDriverFactory&MockObject $vcsDriverFactory;
+
     protected function setUp(): void
     {
+        parent::setUp();
+        self::bootKernel();
+        $this->vcsDriverFactory = $this->createMock(VcsDriverFactory::class);
+        $this->packageVersionFetcher = $this->createMock(PackageVersionFetcher::class);
         $this->importProjectTask = new ImportProjectTask(
-            $this->getEntityManagerMock(),
-            $this->getProjectProviderMock(),
-            $this->getPackageVersionFetcherMock(),
-            $this->createMock(VcsDriverFactory::class),
+            self::$container->get(EntityManagerInterface::class),
+            self::$container->get(ProjectProviderInterface::class),
+            $this->packageVersionFetcher,
+            $this->vcsDriverFactory,
             new NullLogger()
         );
     }
@@ -36,45 +43,10 @@ protected function setUp(): void
      */
     public function import()
     {
-        $this->assertTrue($this->importProjectTask->run('https://foo.git'));
-    }
-
-    /**
-     * @return EntityManagerInterface|MockObject
-     */
-    private function getEntityManagerMock()
-    {
-        $entityManagerMock = $this->createMock(EntityManagerInterface::class);
-        $entityManagerMock
-          ->method('flush')
-          ->will($this->returnValue(null));
-
-        return $entityManagerMock;
-    }
-
-    /**
-     * @return ProjectProviderInterface|MockObject
-     */
-    private function getProjectProviderMock()
-    {
-        $projectProviderMock = $this->createMock(ProjectProviderInterface::class);
-        $projectProviderMock->expects($this->once())
-            ->method('provideProject')
-            ->willReturn(new Project('Foo'));
-
-        return $projectProviderMock;
-    }
-
-    /**
-     * @return PackageVersionFetcher|MockObject
-     */
-    private function getPackageVersionFetcherMock()
-    {
-        $packageVersionFetcherMock = $this->createMock(PackageVersionFetcher::class);
-        $packageVersionFetcherMock->expects($this->once())
-            ->method('fetch')
-            ->willReturn(new ArrayCollection());
+        $this->packageVersionFetcher->method('fetch')->willReturn(
+            new ArrayCollection()
+        );
 
-        return $packageVersionFetcherMock;
+        $this->assertTrue($this->importProjectTask->run('https://foo.git'));
     }
 }