Improve error message when test fails (Case 162267)

janopae · janopae · commit d55ff42d8f28 · 2025-06-11T15:33:17.000+02:00
diff --git a/src/AppBundle/Tests/Entity/VersionConstraintTest.php b/src/AppBundle/Tests/Entity/VersionConstraintTest.php
@@ -35,8 +35,6 @@ public function versionConstraintMatches(string $operator, string $version, arra
 
         $matches = $this->matchPackageVersions($versionConstraint, $packageVersions);
 
-        $this->assertCount(count($expectedMatches), $matches);
-
         $matches = array_map(function ($match) {
             return $match->getPrettyVersion();
         }, $matches);
@@ -48,6 +46,8 @@ public function versionConstraintMatches(string $operator, string $version, arra
         foreach ($nonMatches as $nonMatch) {
             $this->assertNotContains($nonMatch, $matches);
         }
+
+        $this->assertCount(count($expectedMatches), $matches);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,6 @@ public function versionConstraintMatches(string $operator, string $version, arra`
`35`	`35`
`36`	`36`	`$matches = $this->matchPackageVersions($versionConstraint, $packageVersions);`
`37`	`37`
`38`		`- $this->assertCount(count($expectedMatches), $matches);`
`39`		`-`
`40`	`38`	`$matches = array_map(function ($match) {`
`41`	`39`	`return $match->getPrettyVersion();`
`42`	`40`	`}, $matches);`
`@@ -48,6 +46,8 @@ public function versionConstraintMatches(string $operator, string $version, arra`
`48`	`46`	`foreach ($nonMatches as $nonMatch) {`
`49`	`47`	`$this->assertNotContains($nonMatch, $matches);`
`50`	`48`	`}`
	`49`	`+`
	`50`	`+ $this->assertCount(count($expectedMatches), $matches);`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`/**`