Update the test matrix to cover PHP 8.1 to PHP 8.4 (#15)

mpdude · web-flow · commit 41569fdbdbb1 · 2025-11-18T10:18:34.000+01:00
diff --git a/.github/workflows/fix-cs-php.yml b/.github/workflows/fix-cs-php.yml
@@ -7,7 +7,7 @@ on:
 name: Coding Standards
 
 jobs:
-    open-pr-for-cs-violations:
+    fix-cs-issues:
         name: PHP-CS-Fixer
         runs-on: ubuntu-22.04
         if: github.actor != 'dependabot[bot]'
@@ -18,7 +18,7 @@ jobs:
                     ref: ${{ github.head_ref }}
 
             -   name: Run PHP-CS-Fixer
-                uses: docker://ghcr.io/php-cs-fixer/php-cs-fixer:3.62.0-php8.3
+                uses: docker://ghcr.io/php-cs-fixer/php-cs-fixer:3.89.2-php8.4
                 with:
                     args: "fix --show-progress=dots"
 
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -6,27 +6,33 @@ on:
             - master
     pull_request:
 
+env:
+    SYMFONY_DEPRECATIONS_HELPER: weak
+
 jobs:
-    build:
-        runs-on: ubuntu-latest
+    PHPUnit:
+        runs-on: ubuntu-22.04
         strategy:
             fail-fast: false
             matrix:
-                php-version: [ '7.2', '7.4', '8.1', '8.2' ]
-                coverage: none
-                dependency-version: [ prefer-stable ]
-
-        name: PHP ${{ matrix.php-version }} - ${{ matrix.dependency-version }}
-
+                include:
+                    - { php-version: 8.1, dependency-version: prefer-lowest }
+                    - { php-version: 8.3, dependency-version: prefer-stable }
+                    - { php-version: 8.4, dependency-version: prefer-stable }
+        name: PHPUnit (PHP ${{matrix.php-version}}, ${{ matrix.dependency-version }})
         steps:
             -   uses: actions/checkout@v4
-            -   name: Install PHP
-                uses: shivammathur/setup-php@v2
+            -   uses: shivammathur/setup-php@v2
+                with:
+                  php-version: ${{ matrix.php-version }}
+                  coverage: none
+                  tools: composer:v2
+            -   uses: actions/cache@v4
                 with:
-                    php-version: ${{ matrix.php-version }}
-                    coverage: none
-                    extensions: dom
-            -   name: Install dependencies
-                run: composer update --no-interaction --prefer-dist --${{ matrix.dependency-version}} --no-progress --no-suggest
-            -   name: Run test suite
-                run: vendor/bin/phpunit
+                    path: vendor
+                    key: composer-${{ runner.os }}-${{ matrix.php-version }}-${{ matrix.dependency-version }}-${{ hashFiles('composer.json') }}
+                    restore-keys: |
+                        composer-${{ runner.os }}-${{ matrix.php-version }}-${{ matrix.dependency-version }}-
+            -   run: composer update --${{ matrix.dependency-version }} --no-interaction --no-scripts --no-progress --ansi
+            -   run: composer show
+            -   run: vendor/bin/phpunit --display-warnings --display-deprecations
diff --git a/src/Webfactory/Dom/BaseParsingHelper.php b/src/Webfactory/Dom/BaseParsingHelper.php
@@ -1,4 +1,5 @@
 <?php
+
 /*
  * (c) webfactory GmbH <info@webfactory.de>
  *
diff --git a/src/Webfactory/Dom/Exception/EmptyXMLStringException.php b/src/Webfactory/Dom/Exception/EmptyXMLStringException.php
@@ -1,4 +1,5 @@
 <?php
+
 /*
  * (c) webfactory GmbH <info@webfactory.de>
  *
diff --git a/src/Webfactory/Dom/Exception/ParsingException.php b/src/Webfactory/Dom/Exception/ParsingException.php
@@ -1,4 +1,5 @@
 <?php
+
 /*
  * (c) webfactory GmbH <info@webfactory.de>
  *
diff --git a/src/Webfactory/Dom/Exception/ParsingHelperException.php b/src/Webfactory/Dom/Exception/ParsingHelperException.php
@@ -1,4 +1,5 @@
 <?php
+
 /*
  * (c) webfactory GmbH <info@webfactory.de>
  *
diff --git a/src/Webfactory/Dom/HTMLParsingHelper.php b/src/Webfactory/Dom/HTMLParsingHelper.php
@@ -1,4 +1,5 @@
 <?php
+
 /*
  * (c) webfactory GmbH <info@webfactory.de>
  *
diff --git a/src/Webfactory/Dom/PolyglotHTML5ParsingHelper.php b/src/Webfactory/Dom/PolyglotHTML5ParsingHelper.php
@@ -1,4 +1,5 @@
 <?php
+
 /*
  * (c) webfactory GmbH <info@webfactory.de>
  *
diff --git a/src/Webfactory/Dom/XHTML10ParsingHelper.php b/src/Webfactory/Dom/XHTML10ParsingHelper.php
@@ -1,4 +1,5 @@
 <?php
+
 /*
  * (c) webfactory GmbH <info@webfactory.de>
  *
diff --git a/tests/Webfactory/Dom/Test/BaseParsingHelperTest.php b/tests/Webfactory/Dom/Test/BaseParsingHelperTest.php
@@ -1,4 +1,5 @@
 <?php
+
 /*
  * (c) webfactory GmbH <info@webfactory.de>
  *
diff --git a/tests/Webfactory/Dom/Test/HTMLParsingHelperTestCase.php b/tests/Webfactory/Dom/Test/HTMLParsingHelperTestCase.php
@@ -1,4 +1,5 @@
 <?php
+
 /*
  * (c) webfactory GmbH <info@webfactory.de>
  *
diff --git a/tests/Webfactory/Dom/Test/ParsingHelperTestCase.php b/tests/Webfactory/Dom/Test/ParsingHelperTestCase.php
@@ -1,4 +1,5 @@
 <?php
+
 /*
  * (c) webfactory GmbH <info@webfactory.de>
  *
@@ -26,7 +27,7 @@ protected function readDumpAssertFragment(
         $fragment,
         $result = null,
         $declaredNamespacesInDump = null,
-        $declaredNamespacesInRead = null
+        $declaredNamespacesInRead = null,
     ): void {
         if (!$result) {
             $result = $fragment;
diff --git a/tests/Webfactory/Dom/Test/PolyglotHTML5ParsingHelperTest.php b/tests/Webfactory/Dom/Test/PolyglotHTML5ParsingHelperTest.php
@@ -1,4 +1,5 @@
 <?php
+
 /*
  * (c) webfactory GmbH <info@webfactory.de>
  *
diff --git a/tests/Webfactory/Dom/Test/XHTML10ParsingHelperTest.php b/tests/Webfactory/Dom/Test/XHTML10ParsingHelperTest.php
@@ -1,4 +1,5 @@
 <?php
+
 /*
  * (c) webfactory GmbH <info@webfactory.de>
  *

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`<?php`
	`2`	`+`
`2`	`3`	`/*`
`3`	`4`	`* (c) webfactory GmbH <info@webfactory.de>`
`4`	`5`	`*`