Skip to content

Commit f9bbc4d

Browse files
committed
refactor: use vite built-in open-in-editor
1 parent f423542 commit f9bbc4d

File tree

4 files changed

+5
-446
lines changed

4 files changed

+5
-446
lines changed

packages/core/src/Overlay.vue

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,8 +188,12 @@ export default {
188188
this.toggleEnabled()
189189
},
190190
openInEditor(baseUrl, file, line, column) {
191+
/**
192+
* Vite built-in support
193+
* https://github.com/vitejs/vite/blob/d59e1acc2efc0307488364e9f2fad528ec57f204/packages/vite/src/node/server/index.ts#L569-L570
194+
* */
191195
return fetch(
192-
`${baseUrl}/__open-stack-frame-in-editor?file=${file}&line=${line}&column=${column}`,
196+
`${baseUrl}/__open-in-editor?file=${file}:${line}:${column}`,
193197
{
194198
mode: 'no-cors',
195199
},

packages/core/src/index.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import { normalizePath } from 'vite'
66
import type { PluginOption, ServerOptions } from 'vite'
77
import { compileSFCTemplate } from './compiler'
88
import { idToFile, parseVueRequest } from './utils'
9-
import { launchEditorMiddleware, queryParserMiddleware } from './middleware'
109

1110
function getInspectorPath() {
1211
const pluginPath = normalizePath(path.dirname(fileURLToPath(import.meta.url)))
@@ -139,9 +138,6 @@ function VitePluginInspector(options: VitePluginInspectorOptions = DEFAULT_INSPE
139138
return code
140139
},
141140
configureServer(server) {
142-
server.middlewares.use(queryParserMiddleware)
143-
server.middlewares.use(launchEditorMiddleware)
144-
145141
const _printUrls = server.printUrls
146142
server.printUrls = () => {
147143
const { toggleComboKey } = normalizedOptions

0 commit comments

Comments
 (0)