Skip to content

Commit 9b4974a

Browse files
Merge pull request #42 from webfirmframework/dev-wffweb-12
Changes for wffweb-12.0.9
2 parents 33b18e1 + 36abd6a commit 9b4974a

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,15 @@
1414
<java.version>17</java.version>
1515
<maven.compiler.source>${java.version}</maven.compiler.source>
1616
<maven.compiler.target>${java.version}</maven.compiler.target>
17-
<tomcat.version>11.0.10</tomcat.version>
17+
<tomcat.version>11.0.14</tomcat.version>
1818
</properties>
1919

2020

2121
<dependencies>
2222
<dependency>
2323
<groupId>com.webfirmframework</groupId>
2424
<artifactId>wffweb</artifactId>
25-
<version>12.0.8</version>
25+
<version>12.0.9</version>
2626
</dependency>
2727
<dependency>
2828
<groupId>org.apache.tomcat.embed</groupId>

src/main/java/com/webfirmframework/wffwebconfig/page/IndexPage.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,12 @@ public class IndexPage extends BrowserPage {
1616

1717
private static final Logger LOGGER = Logger.getLogger(IndexPage.class.getName());
1818

19-
// this is a standard interval
20-
public static final int HEARTBEAT_TIME_MILLISECONDS = 25000;
19+
// TODO this value is good for good internet speed, increase its value if you have poor internet.
20+
public static final int HEARTBEAT_INTERVAL_MILLISECONDS = 10_000;
21+
22+
// TODO this value is good for good internet speed, increase its value if you have poor internet.
23+
// Note: Make sure that your UI code doesn't block the UI update for more than 2000 milliseconds.
24+
public static final int HEARTBEAT_TIMEOUT_MILLISECONDS = 2_000;
2125

2226
private static final int WS_RECONNECT_TIME = 1000;
2327

@@ -43,7 +47,8 @@ protected void beforeRender() {
4347
// Write BrowserPage configurations code here.
4448
// The following code can also be written inside render() method but
4549
// writing here will be a nice separation of concern.
46-
super.setWebSocketHeartbeatInterval(HEARTBEAT_TIME_MILLISECONDS);
50+
super.setWebSocketHeartbeatInterval(HEARTBEAT_INTERVAL_MILLISECONDS);
51+
super.setWebSocketHeartbeatInterval(HEARTBEAT_TIMEOUT_MILLISECONDS);
4752
super.setWebSocketReconnectInterval(WS_RECONNECT_TIME);
4853
super.setExecutor(AppSettings.CACHED_THREAD_POOL);
4954
}

0 commit comments

Comments
 (0)