review feedback cleanup

Author: zplata

src/wrapper/AssetsUtilitiesClient.ts

@@ -74,37 +74,38 @@ export class Client extends Assets {
     ): Promise<Webflow.AssetUpload> {
         /** 1. Generate the hash */
         const {file, fileName, parentFolder} = request;
-        let tempBuffer: Buffer | null = null;
+        let tempBuffer: Buffer | undefined;
         if (typeof file === 'string') {
             const arrBuffer = await this._getBufferFromUrl(file);
             tempBuffer = Buffer.from(arrBuffer);
         } else if (file instanceof ArrayBuffer) {
             tempBuffer = Buffer.from(file);
         }
-        if (tempBuffer === null) {
-            throw new Error('Invalid file');
+        if (!Buffer.isBuffer(tempBuffer)) {
+            throw new Error('Invalid Buffer: Cannot create a buffer from the provided file');
         }
-        const hash = crypto.createHash("md5").update(Buffer.from(tempBuffer)).digest("hex");
+        const hash = crypto.createHash("md5").update(tempBuffer).digest("hex");
 
         const wfUploadRequest = {
             fileName,
             fileHash: hash,
+            ...(parentFolder && { parentFolder }),
         } as Webflow.AssetsCreateRequest;
-        if (parentFolder) {
-            wfUploadRequest["parentFolder"] = parentFolder;
-        }
 
 
         /** 2. Create the Asset Metadata in Webflow */
         let wfUploadedAsset: Webflow.AssetUpload;
         try {
             wfUploadedAsset = await this.create(siteId, wfUploadRequest, requestOptions);
+            if (!wfUploadedAsset || !wfUploadedAsset.uploadDetails) {
+                throw new Error("Failed to create Asset metadata in Webflow, no S3 headers returned");
+            }
         } catch (error) {
             throw new Error(`Failed to create Asset metadata in Webflow: ${(error as Error).message}`);
         }
 
         /** 3. Create FormData with S3 bucket signature */
-        const wfUploadDetails = wfUploadedAsset.uploadDetails!;
+        const wfUploadDetails = wfUploadedAsset.uploadDetails;
         const uploadUrl = wfUploadedAsset.uploadUrl as string;
         // Temp workaround since headers from response are being camelCased and we need them to be exact when sending to S3
         const headerMappings = {
@@ -126,10 +127,6 @@ export class Client extends Assets {
             formDataToUpload.append(key, transformedUploadHeaders[key]);
         });
 
-        if (!Buffer.isBuffer(tempBuffer)) {
-            throw new Error("Invalid Buffer: Expected a Buffer instance from file");
-        }
-
         formDataToUpload.append("file", tempBuffer, {
             filename: fileName,
             contentType: wfUploadedAsset.contentType || "application/octet-stream",

tests/wrapper/AssetsUtilitiesClient.test.ts

@@ -49,7 +49,7 @@ describe("AssetsUtilitiesClient", () => {
     });
 
     it("should throw an error if it fails to create Webflow Asset metadata", async () => {
-// Mock the Webflow API to throw an error
+        // Mock the Webflow API to throw an error
         jest.spyOn(client, "create").mockRejectedValue(new Error("Webflow API error"));
 
         await expect(client.createAndUpload(siteId, {
@@ -65,7 +65,7 @@ describe("AssetsUtilitiesClient", () => {
     });
 
     it("should throw an error if it fails to upload to S3", async () => {
-// Mock the Webflow API response for creating asset metadata
+        // Mock the Webflow API response for creating asset metadata
         const mockCreateResponse = {
             uploadUrl: mockUploadUrl,
             uploadDetails: {