Add unit tests

Author: webhacking

README.md

@@ -2,6 +2,12 @@
 
 > Request an http(s) url and *scrape its metadata*. It requires [node-html-parser](https://github.com/taoqf/node-html-parser)
 
+<p align="left">
+<a href="https://travis-ci.org/webhacking/url-metadata-parser"><img src="https://travis-ci.org/webhacking/url-metadata-parser.svg?branch=master" alt="Build Status"></a>
+<a href="https://codecov.io/gh/webhacking/sequence-shorten"><img src="https://codecov.io/gh/webhacking/sequence-shorten/branch/master/graph/badge.svg" /></a>
+</p>
+
+
 ## Install
 
 ```

package.json

@@ -5,7 +5,7 @@
   "main": "dist/index.js",
   "scripts": {
     "format": "./node_modules/.bin/prettier --write \"**/*.ts\"",
-    "test": "./node_modules/.bin/jest --testPathIgnorePatterns dist",
+    "test": "./node_modules/.bin/jest",
     "coverage": "./node_modules/.bin/jest --coverage --testPathIgnorePatterns dist",
     "post-coverage": "./node_modules/.bin/nyc report --reporter=json > coverage/coverage.json"
   },
@@ -26,13 +26,36 @@
     "iconv-lite": "^0.4.24",
     "node-html-parser": "^1.1.12",
     "rxjs": "^6.3.3",
-    "ts-node": "^8.0.2",
-    "typescript": "^3.2.4"
+    "ts-node": "^8.0.2"
   },
   "devDependencies": {
     "@types/axios": "^0.14.0",
     "@types/iconv": "^2.1.16",
     "@types/iconv-lite": "0.0.1",
-    "prettier": "^1.17.0"
+    "@types/jest": "^24.0.11",
+    "jest": "^24.7.1",
+    "prettier": "^1.17.0",
+    "ts-jest": "^24.0.2",
+    "typescript": "^3.4.4"
+  },
+  "jest": {
+    "transform": {
+      "^.+\\.ts$": "ts-jest"
+    },
+    "testRegex": "\\.spec\\.ts$",
+    "collectCoverage": true,
+    "moduleFileExtensions": [
+      "ts",
+      "js"
+    ],
+    "globals": {
+      "ts-jest": {
+        "enableTsDiagnostics": true
+      }
+    },
+    "testPathIgnorePatterns": [
+      "./dist",
+      "./node_modules"
+    ]
   }
 }

src/meta.entity.ts

@@ -12,10 +12,10 @@ export class MetaEntity {
   }
 
   public getContentByName(name: string): string | null {
-    return this.tags.map((tag) => (tag.node.childNodes[0] as HTMLElement).attributes).filter(tag => tag.name && tag.name == name)[0] ? this.tags.map((tag) => (tag.node.childNodes[0] as HTMLElement).attributes).filter(tag => tag.name && tag.name === name)[0].content : null;
+    return this.tags.map((tag) => (tag.node.childNodes[0] as HTMLElement).attributes).filter(tag => tag.name && tag.name === name)[0] ? this.tags.map((tag) => (tag.node.childNodes[0] as HTMLElement).attributes).filter(tag => tag.name && tag.name === name)[0].content : null;
   }
 
   public getNameByContent(content: string) {
-    return this.tags.map((tag) => (tag.node.childNodes[0] as HTMLElement).attributes).filter(tag => tag.content && tag.content == content)[0] ? this.tags.map((tag) => (tag.node.childNodes[0] as HTMLElement).attributes).filter(tag => tag.content && tag.content === content)[0].name : null;
+    return this.tags.map((tag) => (tag.node.childNodes[0] as HTMLElement).attributes).filter(tag => tag.content && tag.content === content)[0] ? this.tags.map((tag) => (tag.node.childNodes[0] as HTMLElement).attributes).filter(tag => tag.content && tag.content === content)[0].name : null;
   }
 }

src/metatag.spec.ts

@@ -0,0 +1,25 @@
+import {UrlMetadataParser} from './url-metadata-parser';
+import {Metatag} from './metatag';
+import {MetaEntity} from './meta.entity';
+
+const metaTags = [
+  new Metatag('<meta name="author" content="Woo YeongJun"/>'),
+  new Metatag('<meta name="viewport" content="width=device-width,initial-scale=1.0,minimum-scale=1.0,maximum-scale=1.0,user-scalable=no" />'),
+  new Metatag('<meta property="og:site_name" content="Hax0rs website">')
+];
+
+const metaEntity = new MetaEntity(metaTags);
+
+it('Get contents by name.', () => {
+  expect(metaEntity.getContentByName('author')).toBe('Woo YeongJun');
+});
+
+it('Get name by contents.', () => {
+  expect(metaEntity.getNameByContent('Woo YeongJun')).toBe('author');
+});
+
+it('Get contents by property by name.', () => {
+  expect(metaEntity.getContentByPropertyName('og:site_name')).toBe('Hax0rs website');
+});
+
+

src/url-metadata-parser.ts

@@ -5,8 +5,8 @@ import {concatMap, map} from 'rxjs/operators';
 import {of} from 'rxjs/internal/observable/of';
 import {Metatag} from './metatag';
 import {MetaEntity} from './meta.entity';
+import * as iconvLte from 'iconv-lite';
 
-const iconvLte = require("iconv-lite");
 export type Charset = string;
 export type IntermediateResult = Charset | null;
 export enum Errors {
@@ -30,14 +30,14 @@ export class UrlMetadataParser {
       ['bocu-1', [0xFB, 0xEE, 0x28]],
       ['gb-18030', [0x84, 0x31, 0x95, 0x33]],
     ].map(([c, bytes]: [string, number[]]) => {
-      return ([c, Buffer.from(bytes)] as [Charset, Buffer])
+      return ([c, Buffer.from(bytes)] as [Charset, Buffer]);
     }));
 
     const startsWith = (bom) => {
-      return buf.slice(0, bom.length).equals(bom)
+      return buf.slice(0, bom.length).equals(bom);
     };
 
-    for ( let [charset, bom] of boms ) {
+    for ( const [charset, bom] of boms ) {
       if ( startsWith(bom) ) {
         return of(charset.toUpperCase());
       }
@@ -59,9 +59,9 @@ export class UrlMetadataParser {
             }
             return body.match(/<meta[^>]+>/g).map(val => new Metatag(val));
           })
-        )
+        );
       }),
       map((tags: Metatag[]) => new MetaEntity(tags))
-    )
+    );
   }
 }

tslint.json

@@ -1,9 +1,38 @@
 {
     "defaultSeverity": "error",
-    "extends": [
-        "tslint:recommended"
-    ],
-    "jsRules": {},
-    "rules": {},
+    "extends": ["tslint:recommended"],
+    "jsRules": {
+        "no-unused-expression": true
+    },
+    "rules": {
+        "eofline": false,
+        "quotemark": [true, "single"],
+        "trailing-comma": false,
+        "member-access": false,
+        "indent": false,
+        "ordered-imports": [false],
+        "no-implicit-dependencies": false,
+        "no-unnecessary-initializer": false,
+        "unified-signatures": false,
+        "callable-types": false,
+        "max-line-length": [150],
+        "member-ordering": [false],
+        "curly": false,
+        "interface-name": [false],
+        "array-type": [false],
+        "no-empty-interface": false,
+        "no-empty": false,
+        "arrow-parens": false,
+        "object-literal-sort-keys": false,
+        "no-unused-expression": false,
+        "max-classes-per-file": [false],
+        "ban-types": false,
+        "variable-name": [false],
+        "one-line": [false],
+        "one-variable-per-declaration": [false],
+        "no-return-await": true,
+        "match-default-export-name": true,
+        "prefer-readonly": true
+    },
     "rulesDirectory": []
 }