fix(extensions): Importing-related Improvements (#4894)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: adrians5j <5121148+adrians5j@users.noreply.github.com>

Author: adrians5j

packages/app-admin/src/extensions/AdminExtension.ts

@@ -11,7 +11,8 @@ export const AdminExtension = defineExtension({
     multiple: true,
     paramsSchema: ({ project }) => {
         return z.object({
-            src: zodSrcPath({ project })
+            src: zodSrcPath({ project }),
+            exportName: z.string().optional()
         });
     },
     async build(params, ctx) {
@@ -33,6 +34,11 @@ export const AdminExtension = defineExtension({
             absoluteExtensionFilePath = extensionFilePath;
         }
 
+        const extensionFileName = path.basename(absoluteExtensionFilePath);
+
+        // Export name can be customized or defaults to the file name without extension.
+        const exportName = params.exportName ?? path.parse(extensionFileName).name;
+
         // Generate a constant hash-based component name to avoid using timestamps.
         const hash = crypto.createHash("sha256").update(extensionFilePath).digest("hex");
         const componentName = `AdminExtension_${hash.slice(-10)}`;
@@ -41,7 +47,7 @@ export const AdminExtension = defineExtension({
 
         const importPath = path
             .relative(path.dirname(extensionsTsxFilePath), absoluteExtensionFilePath)
-            .replace(".tsx", ".js");
+            .replace(/\.tsx?$/, ".js");
 
         project.addSourceFileAtPath(extensionsTsxFilePath);
 
@@ -66,15 +72,15 @@ export const AdminExtension = defineExtension({
             index = last.getChildIndex() + 1;
         }
 
-        // Import as default export if available, otherwise import named "Extension" export
+        // Import as default export if available, otherwise import named export
         if (hasDefaultExport) {
             source.insertImportDeclaration(index, {
                 defaultImport: componentName,
                 moduleSpecifier: importPath
             });
         } else {
             source.insertImportDeclaration(index, {
-                namedImports: [{ name: "Extension", alias: componentName }],
+                namedImports: [{ name: exportName, alias: componentName }],
                 moduleSpecifier: importPath
             });
         }

packages/project/src/defineExtension/defineApiExtension.ts

@@ -46,21 +46,17 @@ export const defineApiExtension = (params: DefineApiExtensionParams) =>
             const extensionFileName = path.basename(absoluteExtensionFilePath);
 
             // 1. Export name is always the file name without extension.
-            const exportName = params.exportName ?? extensionFileName.replace(".ts", "");
+            const exportName = params.exportName ?? path.parse(extensionFileName).name;
 
             // 2. Alias name is "ApiExtension_" + hash of the file path. This way we
             //    avoid potential naming conflicts and keep the identifier constant.
             const hash = crypto.createHash("sha256").update(extensionFilePath).digest("hex");
             const exportNameAlias = `ApiExtension_${hash.slice(-10)}`;
 
             // 3. Calculate import path relative to `extensions.ts` file.
-            const importPath = [
-                path.relative(
-                    path.dirname(extensionsTsFilePath),
-                    path.dirname(absoluteExtensionFilePath)
-                ),
-                extensionFileName.replace(".ts", ".js")
-            ].join("/");
+            const importPath = path
+                .relative(path.dirname(extensionsTsFilePath), absoluteExtensionFilePath)
+                .replace(/\.tsx?$/, ".js");
 
             const project = new Project();
             project.addSourceFileAtPath(extensionsTsFilePath);
@@ -80,9 +76,12 @@ export const defineApiExtension = (params: DefineApiExtensionParams) =>
                 index = last.getChildIndex() + 1;
             }
 
-            // Check if the file has a default export by importing it.
-            const importedModule = await import(absoluteExtensionFilePath);
-            const hasDefaultExport = "default" in importedModule;
+            // Check if the file has a default export using AST parsing.
+            const extensionProject = new Project();
+            extensionProject.addSourceFileAtPath(absoluteExtensionFilePath);
+            const extensionSource =
+                extensionProject.getSourceFileOrThrow(absoluteExtensionFilePath);
+            const hasDefaultExport = extensionSource.getDefaultExportSymbol() !== undefined;
 
             // Support both default and named exports.
             if (hasDefaultExport) {