Skip to content

Commit e1d21d8

Browse files
Improve naming of API endpoints
1 parent 100d14c commit e1d21d8

File tree

3 files changed

+55
-35
lines changed

3 files changed

+55
-35
lines changed

backend/backend.py

Lines changed: 35 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ def __call__(self, environ, start_response):
100100
class ClassifyNewWD(Resource):
101101
def post(self):
102102
"""
103-
Classifies input text to argument structure (Essays model, fasttext - big dataset)
103+
Classifies input text to argument structure (WebD model, GloVe embeddings)
104104
---
105105
consumes:
106106
- text/plain
@@ -132,7 +132,7 @@ def post(self):
132132
class ClassifyNewPE(Resource):
133133
def post(self):
134134
"""
135-
Classifies input text to argument structure (Essays model, fasttext embeddings)
135+
Classifies input text to argument structure (Essays model, GloVe embeddings)
136136
137137
---
138138
consumes:
@@ -165,7 +165,7 @@ def post(self):
165165
class ClassifyES(Resource):
166166
def post(self):
167167
"""
168-
Classifies input text to argument structure (Essays model, fasttext embeddings)
168+
Classifies input text to argument structure (Essays model, fastText embeddings)
169169
---
170170
consumes:
171171
- text/plain
@@ -197,7 +197,7 @@ def post(self):
197197
class ClassifyWD(Resource):
198198
def post(self):
199199
"""
200-
Classifies input text to argument structure (WebD model, fasttext - big dataset)
200+
Classifies input text to argument structure (WebD model, fastText embeddings)
201201
---
202202
consumes:
203203
- text/plain
@@ -229,7 +229,7 @@ def post(self):
229229
class ClassifyES_dep(Resource):
230230
def post(self):
231231
"""
232-
Classifies input text to argument structure (Essays model, dependency based)
232+
Classifies input text to argument structure (Essays model, dependency-based embeddings)
233233
---
234234
consumes:
235235
- text/plain
@@ -261,7 +261,7 @@ def post(self):
261261
class ClassifyWD_dep(Resource):
262262
def post(self):
263263
"""
264-
Classifies input text to argument structure (WebD model, dependency based)
264+
Classifies input text to argument structure (WebD model, dependency-based embeddings)
265265
---
266266
consumes:
267267
- text/plain
@@ -293,7 +293,7 @@ def post(self):
293293
class ClassifyIBM(Resource):
294294
def post(self):
295295
"""
296-
Classifies input text to argument structure (IBM model, fasttext - big dataset)
296+
Classifies input text to argument structure (IBM model, fastText embeddings)
297297
---
298298
consumes:
299299
- text/plain
@@ -325,7 +325,7 @@ def post(self):
325325
class ClassifyCombo(Resource):
326326
def post(self):
327327
"""
328-
Classifies input text to argument structure (Combo model - big dataset)
328+
Classifies input text to argument structure (Combo model from <a href="https://github.com/uhh-lt/targer/blob/a2a89ebfb366bc723a38dae963f8cb8b130f7e81/backend/backend.py#L305">Universität Hamburg</a>)
329329
---
330330
consumes:
331331
- text/plain
@@ -354,14 +354,34 @@ def post(self):
354354
return response
355355

356356

357-
api.add_resource(ClassifyES, '/classifyES')
358-
api.add_resource(ClassifyWD, '/classifyWD')
359-
api.add_resource(ClassifyES_dep, '/classifyES_dep')
360-
api.add_resource(ClassifyWD_dep, '/classifyWD_dep')
361-
api.add_resource(ClassifyIBM, '/classifyIBM')
357+
class DeprecatedResource(Resource):
358+
def __init__(self, resource: Resource):
359+
self.resource = resource
360+
361+
def post(self):
362+
"""
363+
Deprecated.
364+
---
365+
deprecated: true
366+
"""
367+
return self.resource.post()
368+
369+
370+
api.add_resource(ClassifyIBM, '/classifyIBMfasttext')
371+
api.add_resource(ClassifyES_dep, '/classifyPEdep')
372+
api.add_resource(ClassifyES, '/classifyPEfasttext')
373+
api.add_resource(ClassifyNewPE, '/classifyPEglove')
374+
api.add_resource(ClassifyWD_dep, '/classifyWDdep')
375+
api.add_resource(ClassifyWD, '/classifyWDfasttext')
376+
api.add_resource(ClassifyNewWD, '/classifyWDglove')
362377
api.add_resource(ClassifyCombo, '/classifyCombo')
363-
api.add_resource(ClassifyNewPE, '/classifyNewPE')
364-
api.add_resource(ClassifyNewWD, '/classifyNewWD')
378+
api.add_resource(DeprecatedResource(ClassifyIBM), '/classifyIBM')
379+
api.add_resource(DeprecatedResource(ClassifyES_dep), '/classifyES_dep')
380+
api.add_resource(DeprecatedResource(ClassifyES), '/classifyES')
381+
api.add_resource(DeprecatedResource(ClassifyNewPE), '/classifyNewPE')
382+
api.add_resource(DeprecatedResource(ClassifyWD_dep), '/classifyWD_dep')
383+
api.add_resource(DeprecatedResource(ClassifyWD), '/classifyWD')
384+
api.add_resource(DeprecatedResource(ClassifyNewWD), '/classifyNewWD')
365385

366386
app.jinja_env.auto_reload = True
367387
app.config['TEMPLATES_AUTO_RELOAD'] = True

frontend/frontend.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -72,22 +72,22 @@ def create_api_url(endpoint):
7272
class Sender:
7373
def send(self, text, classifier):
7474

75-
if classifier == "WD":
76-
url = create_api_url("classifyWD")
77-
elif classifier == "WD_dep":
78-
url = create_api_url("classifyWD_dep")
79-
elif classifier == "ES":
80-
url = create_api_url("classifyES")
75+
if classifier == "IBM":
76+
url = create_api_url("classifyIBMfasttext")
8177
elif classifier == "ES_dep":
82-
url = create_api_url("classifyES_dep")
83-
elif classifier == "IBM":
84-
url = create_api_url("classifyIBM")
85-
elif classifier == "Combo":
86-
url = create_api_url("classifyCombo")
78+
url = create_api_url("classifyPEdep")
79+
elif classifier == "ES":
80+
url = create_api_url("classifyPEfasttext")
8781
elif classifier == "NEWPE":
88-
url = create_api_url("classifyNewPE")
82+
url = create_api_url("classifyPEglove")
83+
elif classifier == "WD_dep":
84+
url = create_api_url("classifyWDdep")
85+
elif classifier == "WD":
86+
url = create_api_url("classifyWDfasttext")
8987
elif classifier == "NEWWD":
90-
url = create_api_url("classifyNewWD")
88+
url = create_api_url("classifyWDglove")
89+
elif classifier == "Combo":
90+
url = create_api_url("classifyCombo")
9191

9292
try:
9393
r = requests.post(url, data=text.encode("utf-8"))

frontend/templates/template_main.html

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -80,13 +80,13 @@ <h5 class="card-title">Argument Tagger</h5>
8080
<div class="form-row">
8181
<label for="model">Model to label with</label>
8282
<select class="form-control" id="model">
83-
<option value="ES">Essays (fastText)</option>
84-
<option value="ES_dep">Essays (Dependency)</option>
85-
<option value="NEWPE">Essays (Glove)</option>
86-
<option value="WD">WebDiscourse (fastText)</option>
87-
<option value="WD_dep">WebDiscourse (Dependency)</option>
88-
<option value="NEWWD">WebDiscourse (Glove)</option>
89-
<option value="IBM" selected="selected">IBM (fastText)</option>
83+
<option value="IBM" selected="selected">IBM (fastText embeddings)</option>
84+
<option value="ES_dep">Essays (dependency-based embeddings)</option>
85+
<option value="ES">Essays (fastText embeddings)</option>
86+
<option value="NEWPE">Essays (GloVe embeddings)</option>
87+
<option value="WD_dep">WebDiscourse (dependency-based embeddings)</option>
88+
<option value="WD">WebDiscourse (fastText embeddings)</option>
89+
<option value="NEWWD">WebDiscourse (GloVe embeddings)</option>
9090
<option value="Combo">Combo</option>
9191
</select>
9292
</div>

0 commit comments

Comments
 (0)