Merge pull request #275 from webmachine/rubocop

Rubocop: resolve CI breaking issues

Author: seancribbs

.rubocop.yml

@@ -51,4 +51,6 @@ Style/GlobalVars:
     - "lib/webmachine/decision/conneg.rb"
 
 AllCops:
+  NewCops: disable
   SuggestExtensions: false
+  TargetRubyVersion: 2.6

lib/webmachine/dispatcher/route.rb

@@ -37,7 +37,7 @@ def self.rfc3986_percent_decode(value)
           result << if encoded_val.nil?
             s.getch
           else
-            [encoded_val[1..-1]].pack('H*')
+            [encoded_val[1..]].pack('H*')
           end
         end
         result
@@ -154,8 +154,8 @@ def bind(tokens, bindings)
           else
             return false
           end
-          spec = spec[1..-1]
-          tokens = tokens[1..-1]
+          spec = spec[1..]
+          tokens = tokens[1..]
           depth += 1
         end
       end

lib/webmachine/headers.rb

@@ -37,12 +37,12 @@ def self.[](*args)
 
     # Fetch a header
     def [](key)
-      super transform_key(key)
+      super(transform_key(key))
     end
 
     # Set a header
     def []=(key, value)
-      super transform_key(key), value
+      super(transform_key(key), value)
     end
 
     # Returns the value for the given key. If the key can't be found,
@@ -70,7 +70,7 @@ def fetch(*args, &block)
 
     # Delete a header
     def delete(key)
-      super transform_key(key)
+      super(transform_key(key))
     end
 
     # Select matching headers

lib/webmachine/quoted_string.rb

@@ -28,7 +28,7 @@ def quote(str)
 
     # Escapes quotes within a quoted string.
     def escape_quotes(str)
-      str.gsub(/"/, '\\"')
+      str.gsub('"', '\\"')
     end
 
     # Unescapes quotes within a quoted string

lib/webmachine/resource/authentication.rb

@@ -24,7 +24,7 @@ module Authentication
       # @yieldparam [String] password the passed password
       # @yieldreturn [true,false] whether the username/password is correct
       def basic_auth(header, realm = 'Webmachine')
-        if header =~ BASIC_HEADER && yield(*$1.unpack1('m*').split(/:/, 2))
+        if header =~ BASIC_HEADER && yield(*$1.unpack1('m*').split(':', 2))
           true
         else
           %(Basic realm="#{realm}")