Skip to content

Commit dfa0c91

Browse files
committed
type hinted interfaces for service decoration
1 parent 29a34e6 commit dfa0c91

File tree

5 files changed

+19
-13
lines changed

5 files changed

+19
-13
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
## [3.2.3]
22
- Cast boolean property values properly
3+
- type hinted interfaces for service decoration
34

45
## [3.2.2]
56
- Filter smarty syntax before compiling and strip json induced escapes

Services/TagManagerVariablesInterface.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,9 @@ public function render($module);
4343
* @return string
4444
*/
4545
public function prependDataLayer($source, $prettyPrint = false);
46+
47+
/**
48+
* @param string $module
49+
*/
50+
public function setModule($module);
4651
}

Subscriber/Frontend/Dispatch.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,15 @@
1717
namespace WbmTagManager\Subscriber\Frontend;
1818

1919
use Enlight\Event\SubscriberInterface;
20-
use WbmTagManager\Services\TagManagerVariables;
20+
use WbmTagManager\Services\TagManagerVariablesInterface;
2121

2222
/**
2323
* Class Dispatch
2424
*/
2525
class Dispatch extends ConfigAbstract implements SubscriberInterface
2626
{
2727
/**
28-
* @var TagManagerVariables
28+
* @var TagManagerVariablesInterface
2929
*/
3030
private $variables;
3131

@@ -40,13 +40,13 @@ class Dispatch extends ConfigAbstract implements SubscriberInterface
4040
private $session;
4141

4242
/**
43-
* @param TagManagerVariables $variables
43+
* @param TagManagerVariablesInterface $variables
4444
* @param \Shopware_Components_Config $config
4545
* @param array $modules
4646
* @param \Enlight_Components_Session_Namespace $session
4747
*/
4848
public function __construct(
49-
TagManagerVariables $variables,
49+
TagManagerVariablesInterface $variables,
5050
\Shopware_Components_Config $config,
5151
$modules,
5252
\Enlight_Components_Session_Namespace $session

Subscriber/Frontend/FilterRender.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,15 @@
1717
namespace WbmTagManager\Subscriber\Frontend;
1818

1919
use Enlight\Event\SubscriberInterface;
20-
use WbmTagManager\Services\TagManagerVariables;
20+
use WbmTagManager\Services\TagManagerVariablesInterface;
2121

2222
/**
2323
* Class FilterRender
2424
*/
2525
class FilterRender extends ConfigAbstract implements SubscriberInterface
2626
{
2727
/**
28-
* @var TagManagerVariables
28+
* @var TagManagerVariablesInterface
2929
*/
3030
private $variables;
3131

@@ -40,13 +40,13 @@ class FilterRender extends ConfigAbstract implements SubscriberInterface
4040
private $pluginDir;
4141

4242
/**
43-
* @param TagManagerVariables $variables
44-
* @param \Shopware_Components_Config $config
45-
* @param \Enlight_Controller_Front $front
46-
* @param string $pluginDir
43+
* @param TagManagerVariablesInterface $variables
44+
* @param \Shopware_Components_Config $config
45+
* @param \Enlight_Controller_Front $front
46+
* @param string $pluginDir
4747
*/
4848
public function __construct(
49-
TagManagerVariables $variables,
49+
TagManagerVariablesInterface $variables,
5050
\Shopware_Components_Config $config,
5151
\Enlight_Controller_Front $front,
5252
$pluginDir

plugin.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
<compatibility minVersion="5.2.0" />
1010

1111
<changelog version="3.2.3">
12-
<changes lang="de">Cast boolean property values properly</changes>
13-
<changes lang="en">Typumwandlung boolescher Werte in Eigenschaften</changes>
12+
<changes lang="de">Cast boolean property values properly, type hinted interfaces for service decoration</changes>
13+
<changes lang="en">Typumwandlung boolescher Werte in Eigenschaften, typed hinted Interfaces zur Service Decoration</changes>
1414
</changelog>
1515

1616
<changelog version="3.2.2">

0 commit comments

Comments
 (0)