Add Node.js support

Fixes #2.

Squashed commit of the following:

commit 5d261ee
Author: Shahar Or <[email protected]>
Date:   Mon Feb 9 20:50:22 2015 +0200

    Makefile: fixed

commit 7c35b64
Author: Shahar Or <[email protected]>
Date:   Mon Feb 9 20:29:38 2015 +0200

    rm extra blank line

commit 3dbcd75
Author: Shahar Or <[email protected]>
Date:   Mon Feb 9 20:25:56 2015 +0200

    Do not browserify jsdom by package.json, not .zuul.yml

commit d1db1b3
Author: Shahar Or <[email protected]>
Date:   Mon Feb 9 20:22:16 2015 +0200

    spec: don't use node-detect. check typeof window

commit a3e0a9b
Author: Shahar Or <[email protected]>
Date:   Mon Feb 9 20:16:55 2015 +0200

    test: clean up spec-specific child elements

commit e7cee9e
Author: Shahar Or <[email protected]>
Date:   Mon Feb 9 20:14:05 2015 +0200

    Use package.json browser field for not expecting window in non-browser

commit f144af4
Author: Shahar Or <[email protected]>
Date:   Wed Jan 28 23:12:17 2015 +0200

    Makefile: fix `test` command

commit a9e5b66
Author: Shahar Or <[email protected]>
Date:   Wed Jan 28 22:49:31 2015 +0200

    Fix for use in node.js

Author: mightyiam

Makefile

@@ -8,17 +8,21 @@ BIN := $(THIS_DIR)/node_modules/.bin
 
 # applications
 NODE ?= node
+MOCHA ?= $(NODE) $(BIN)/mocha
 ZUUL ?= $(NODE) $(BIN)/zuul
 
 test:
-	@if [ "x$(BROWSER_PLATFORM)" = "x" ]; then \
-		$(ZUUL) \
-		--ui mocha-bdd \
-		--browser-name $(BROWSER_NAME) \
-		--browser-version $(BROWSER_VERSION) \
-		test/*.js; \
+	@if [ "x$(BROWSER_NAME)" = "x" ]; then \
+		$(MAKE) test-node; \
 		else \
-	$(ZUUL) \
+		$(MAKE) test-zuul; \
+	fi
+
+test-node:
+	@$(MOCHA) test/*.js
+
+test-zuul:
+	@$(ZUUL) \
 		--ui mocha-bdd \
 		--browser-name $(BROWSER_NAME) \
 		--browser-version $(BROWSER_VERSION) \

index.js

@@ -11,8 +11,7 @@ var getDocument = require('get-document');
 
 module.exports = getWindow;
 
-// old-IE fallback logic: http://stackoverflow.com/a/10260692
-var needsIEFallback = !!document.attachEvent && window !== document.parentWindow;
+var needsIEFallback = require('./needs-ie-fallback');
 
 /**
  * Returns `true` if `w` is a Window object, or `false` otherwise.

needs-ie-fallback.br.js

@@ -0,0 +1,4 @@
+// this is a browser-only module. There is a non-browser equivalent in the same
+// directory. This is done using a `package.json` browser field.
+// old-IE fallback logic: http://stackoverflow.com/a/10260692
+module.exports =  !!document.attachEvent && window !== document.parentWindow;

needs-ie-fallback.js

@@ -0,0 +1,2 @@
+// there is a browser-specific, equivalent, module in the same directory
+module.exports = false;

package.json

@@ -14,6 +14,10 @@
     "browser"
   ],
   "main": "index.js",
+  "browser": {
+      "./needs-ie-fallback.js": "needs-ie-fallback.br.js",
+      "jsdom": false
+  },
   "dependencies": {
     "get-document": "1"
   },
@@ -27,6 +31,8 @@
     "url": "https://github.com/webmodules/get-window.git"
   },
   "devDependencies": {
+    "jsdom": "^3.1.0",
+    "mocha": "^2.1.0",
     "zuul": "~1.16.5"
   }
 }

test/test.js

@@ -3,95 +3,109 @@ var assert = require('assert');
 var getWindow = require('../');
 var getDocument = require('get-document');
 
+var inBrowser = typeof window !== 'undefined';
+
+// Zuul is configured to pass on to Browserify a configuration to exclude the
+// following module, 'jsdom' because it is only for testing in node. Browsers
+// have real dom
+var jsdom = !inBrowser ? require('jsdom') : null;
+
+var doc = inBrowser ? document : jsdom.jsdom();
+var win = inBrowser ? window : doc.parentWindow;
+
 describe('get-window', function () {
 
   it('should work with the global Window object', function () {
-    var win = getWindow(window);
-    assert(win === window);
+    var result = getWindow(win);
+    assert(result === win);
   });
 
   it('should work with the global Document object', function () {
-    var win = getWindow(document);
-    assert(win === window);
+    var result = getWindow(doc);
+    assert(result === win);
   });
 
   it('should work with the `document.body` object', function () {
-    var win = getWindow(document.body);
-    assert(win === window);
+    var result = getWindow(doc.body);
+    assert(result === win);
   });
 
   it('should work with the a DOM element inside `document.body`', function () {
-    var win = getWindow(document.body.firstChild);
-    assert(win === window);
+    var p = doc.createElement('p')
+    doc.body.appendChild(p);
+    var result = getWindow(doc.body.firstChild);
+    assert(result === win);
+    doc.body.removeChild(p);
   });
 
   it('should work with a new DOM element', function () {
-    var win = getWindow(document.createElement('div'));
-    assert(win === window);
+    var result = getWindow(doc.createElement('div'));
+    assert(result === win);
   });
 
   it('should work with a new TextNode', function () {
-    var win = getWindow(document.createTextNode(''));
-    assert(win === window);
+    var result = getWindow(doc.createTextNode(''));
+    assert(result === win);
   });
 
   // skip on IE <= 8
-  if ('function' === typeof document.createRange) {
+  if ('function' === typeof doc.createRange) {
     it('should work with a DOM Range instance', function () {
-      var win = getWindow(document.createRange());
-      assert(win === window);
+      var result = getWindow(doc.createRange());
+      assert(result === win);
     });
   }
 
   // skip on IE <= 8
-  if ('function' === typeof window.getSelection) {
+  if ('function' === typeof win.getSelection) {
     it('should work with a DOM Selection instance', function () {
       // NOTE: a Selection needs to have some kind of selection on it
       // (i.e. not `type: "None"`) in order for a Document to be found
-      var range = document.createRange();
-      var t = document.createTextNode('t');
-      document.body.appendChild(t);
+      var range = doc.createRange();
+      var t = doc.createTextNode('t');
+      doc.body.appendChild(t);
       range.setStart(t, 0);
       range.setEnd(t, t.nodeValue.length);
 
-      var sel = window.getSelection();
+      var sel = win.getSelection();
       sel.removeAllRanges();
       sel.addRange(range);
       assert.equal(1, sel.rangeCount);
 
-      var win = getWindow(sel);
-      assert(win === window);
+      var result = getWindow(sel);
+      assert(result === win);
 
       // clean up
       sel.removeAllRanges();
+      doc.body.removeChild(t)
     });
   }
 
   it('should work with the child node of an IFRAME element', function () {
-    var iframe = document.createElement('iframe');
-    document.body.appendChild(iframe);
+    var iframe = doc.createElement('iframe');
+    doc.body.appendChild(iframe);
 
     // `contentWindow` should be used for best browser compatibility
-    var doc = getDocument(iframe.contentWindow);
-    assert.equal(9, doc.nodeType);
+    var iframeDoc = getDocument(iframe.contentWindow);
+    assert.equal(9, iframeDoc.nodeType);
 
-    doc.open();
-    doc.write('<body><b>hello world</b></body>');
-    doc.close();
+    iframeDoc.open();
+    iframeDoc.write('<body><b>hello world</b></body>');
+    iframeDoc.close();
 
-    var win = getWindow(doc);
-    assert(win);
-    assert(win !== window);
+    var result = getWindow(iframeDoc);
+    assert(result );
+    assert(result !== win);
 
     // test the <body>
-    var body = doc.body;
-    assert(win === getWindow(body));
+    var body = iframeDoc.body;
+    assert(result === getWindow(body));
 
     // test the <b> node
-    assert(win === getWindow(body.firstChild));
+    assert(result === getWindow(body.firstChild));
 
     // clean up
-    document.body.removeChild(iframe);
+    doc.body.removeChild(iframe);
   });
 
 });