:exclusions collides with Lein :exclusions

[vemv]

Hi!

Great plugin, thank you for your work.

I noticed that it observes a key named :exclusions. However that name already has associated semantics:

https://github.com/technomancy/leiningen/blob/e270102447fb9ca1f33591d39b72b15d06cdc0ef/sample.project.clj#L91

Could you observe a new name?

Thanks - V

[vemv]

My question is somewhat wrong as :exclusions is not read from project.clj but as a CLI option.

However it would be nice/idiomatic if one could specify the exclusions as part of the project map, so that that info is version-controlled, expressed as data (vs. escaped string) etc

[bendlas]

Glad you're enjoying it.

Not sure about this ticket. It seems idiomatic in clojure, to re-use names if appropriate, and as you noted it doesn't collide in the project descriptor.

Happy to discuss adding a project.clj key, and switch to another key than :webnf.lein-collisions/exclusions on the way. I'd definitely keep the current command line option as a deprecated alias, though ...

Any suggestions for a new name?

[vemv]

Hi @bendlas cheers for the quick and positive reply on all three issues 🍻

Happy to discuss adding a project.clj key, and switch to another key than :webnf.lein-collisions/exclusions on the way. I'd definitely keep the current command line option as a deprecated alias, though ...

Sounds good to me, and agreed that :webnf.lein-collisions might be a bit over the top. Maybe simply :lein-collisions {:exclusions ... would be clear and unique enough. I don't see hits for https://grep.app/search?q=%3Alein-collisions as a keyword.

Granted, there's a little bit of ambiguity as for whether :lein-collisions would refer to some Lein official feature, but probably lein-* as a naming convention for plugins is enough of a hint.