Skip to content

Commit 03be662

Browse files
authored
Merge pull request #1678 from simPod/assert
test: improve few assertions
2 parents 7d1da83 + 88d9c7d commit 03be662

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

tests/Utils/AstGetOperationAstTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public function testGetsAnOperationFromADcoumentWithNamedOpSubscription(): void
3838
public function testDoesNotGetMissingOperation(): void
3939
{
4040
$doc = Parser::parse('type Foo { field: String }');
41-
self::assertEquals(AST::getOperationAST($doc), null);
41+
self::assertNull(AST::getOperationAST($doc));
4242
}
4343

4444
/** @see it('Does not get ambiguous unnamed operation') */
@@ -49,7 +49,7 @@ public function testDoesNotGetAmbiguousUnnamedOperation(): void
4949
mutation Test { field }
5050
subscription TestSub { field }
5151
');
52-
self::assertEquals(AST::getOperationAST($doc), null);
52+
self::assertNull(AST::getOperationAST($doc));
5353
}
5454

5555
/** @see it('Does not get ambiguous named operation') */
@@ -60,7 +60,7 @@ public function testDoesNotGetAmbiguousNamedOperation(): void
6060
mutation TestM { field }
6161
subscription TestS { field }
6262
');
63-
self::assertEquals(AST::getOperationAST($doc), null);
63+
self::assertNull(AST::getOperationAST($doc));
6464
}
6565

6666
/** @see it('Does not get misnamed operation') */
@@ -72,7 +72,7 @@ public function testDoesNotGetMisnamedOperation(): void
7272
mutation TestM { field }
7373
subscription TestS { field }
7474
');
75-
self::assertEquals(AST::getOperationAST($doc, 'Unknown'), null);
75+
self::assertNull(AST::getOperationAST($doc, 'Unknown'));
7676
}
7777

7878
/** @see it('Gets named operation') */

tests/Utils/MixedStoreTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ private function assertProvidesArrayAccess($key, $value): void
8383
self::assertFalse(isset($this->mixedStore[$key]), $err);
8484
$this->mixedStore[$key] = $value;
8585
self::assertTrue(isset($this->mixedStore[$key]), $err);
86-
self::assertEquals((bool) $value, (bool) $this->mixedStore[$key], $err);
86+
self::assertSame((bool) $value, (bool) $this->mixedStore[$key], $err);
8787
self::assertSame($value, $this->mixedStore[$key], $err);
8888
unset($this->mixedStore[$key]);
8989
self::assertFalse(isset($this->mixedStore[$key]), $err);

0 commit comments

Comments
 (0)