Merge pull request #89 from aldumas/assign_fix

Fixed Utils::assign() bug relating to detecting missing required keys

Author: vladar

src/Utils.php

@@ -25,7 +25,7 @@ public static function undefined()
     public static function assign($obj, array $vars, array $requiredKeys = [])
     {
         foreach ($requiredKeys as $key) {
-            if (!isset($key, $vars)) {
+            if (!isset($vars[$key])) {
                 throw new InvalidArgumentException("Key {$key} is expected to be set and not to be null");
             }
         }

tests/UtilsTest.php

@@ -0,0 +1,22 @@
+<?php
+namespace GraphQL\Tests;
+
+use GraphQL\Utils;
+
+class UtilsTest extends \PHPUnit_Framework_TestCase
+{
+    public function testAssignThrowsExceptionOnMissingRequiredKey()
+    {
+        $object = new \stdClass();
+        $object->requiredKey = 'value';
+
+        try {
+            Utils::assign($object, [], ['requiredKey']);
+            $this->fail('Expected exception not thrown');
+        } catch (\InvalidArgumentException $e) {
+            $this->assertEquals(
+                "Key requiredKey is expected to be set and not to be null",
+                $e->getMessage());
+        }
+    }
+}