Update phpstan packages (#1217)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: spawnia <benedikt@franke.tech>

Author: renovate[bot]

composer.json

@@ -21,9 +21,9 @@
     "nyholm/psr7": "^1.5",
     "phpbench/phpbench": "^1.2",
     "phpstan/extension-installer": "^1.1",
-    "phpstan/phpstan": "1.8.2",
+    "phpstan/phpstan": "1.8.4",
     "phpstan/phpstan-phpunit": "1.1.1",
-    "phpstan/phpstan-strict-rules": "1.4.2",
+    "phpstan/phpstan-strict-rules": "1.4.3",
     "phpunit/phpunit": "^9.5",
     "psalm/plugin-phpunit": "^0.17",
     "psr/http-message": "^1",

src/Validator/Rules/KnownDirectives.php

@@ -145,64 +145,47 @@ protected function getDirectiveLocationForASTPath(array $ancestors): string
                 switch ($appliedTo->operation) {
                     case 'query':
                         return DirectiveLocation::QUERY;
-
                     case 'mutation':
                         return DirectiveLocation::MUTATION;
-
                     case 'subscription':
                         return DirectiveLocation::SUBSCRIPTION;
                 }
-
-                break;
+                // no break, since all possible cases were handled
             case $appliedTo instanceof FieldNode:
                 return DirectiveLocation::FIELD;
-
             case $appliedTo instanceof FragmentSpreadNode:
                 return DirectiveLocation::FRAGMENT_SPREAD;
-
             case $appliedTo instanceof InlineFragmentNode:
                 return DirectiveLocation::INLINE_FRAGMENT;
-
             case $appliedTo instanceof FragmentDefinitionNode:
                 return DirectiveLocation::FRAGMENT_DEFINITION;
-
             case $appliedTo instanceof VariableDefinitionNode:
                 return DirectiveLocation::VARIABLE_DEFINITION;
-
             case $appliedTo instanceof SchemaDefinitionNode:
             case $appliedTo instanceof SchemaExtensionNode:
                 return DirectiveLocation::SCHEMA;
-
             case $appliedTo instanceof ScalarTypeDefinitionNode:
             case $appliedTo instanceof ScalarTypeExtensionNode:
                 return DirectiveLocation::SCALAR;
-
             case $appliedTo instanceof ObjectTypeDefinitionNode:
             case $appliedTo instanceof ObjectTypeExtensionNode:
                 return DirectiveLocation::OBJECT;
-
             case $appliedTo instanceof FieldDefinitionNode:
                 return DirectiveLocation::FIELD_DEFINITION;
-
             case $appliedTo instanceof InterfaceTypeDefinitionNode:
             case $appliedTo instanceof InterfaceTypeExtensionNode:
                 return DirectiveLocation::IFACE;
-
             case $appliedTo instanceof UnionTypeDefinitionNode:
             case $appliedTo instanceof UnionTypeExtensionNode:
                 return DirectiveLocation::UNION;
-
             case $appliedTo instanceof EnumTypeDefinitionNode:
             case $appliedTo instanceof EnumTypeExtensionNode:
                 return DirectiveLocation::ENUM;
-
             case $appliedTo instanceof EnumValueDefinitionNode:
                 return DirectiveLocation::ENUM_VALUE;
-
             case $appliedTo instanceof InputObjectTypeDefinitionNode:
             case $appliedTo instanceof InputObjectTypeExtensionNode:
                 return DirectiveLocation::INPUT_OBJECT;
-
             case $appliedTo instanceof InputValueDefinitionNode:
                 $parentNode = $ancestors[count($ancestors) - 3];