Fixed failed integer test (only fails on some OSs and PHP versions)

vladar · vladar · commit 2023b427aec3 · 2017-09-20T16:20:51.000+07:00
diff --git a/src/Type/Definition/IntType.php b/src/Type/Definition/IntType.php
@@ -74,7 +74,10 @@ public function serialize($value)
      */
     public function parseValue($value)
     {
-        return (is_int($value) && $value <= self::MAX_INT && $value >= self::MIN_INT) ? $value : null;
+        // Below is a fix against PHP bug where (in some combinations of OSs and versions)
+        // boundary values are treated as "double" vs "integer" and failing is_int() check
+        $isInt = is_int($value) || $value === self::MIN_INT || $value === self::MAX_INT;
+        return $isInt && $value <= self::MAX_INT && $value >= self::MIN_INT ? $value : null;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,10 @@ public function serialize($value)`
`74`	`74`	`*/`
`75`	`75`	`public function parseValue($value)`
`76`	`76`	`{`
`77`		`- return (is_int($value) && $value <= self::MAX_INT && $value >= self::MIN_INT) ? $value : null;`
	`77`	`+ // Below is a fix against PHP bug where (in some combinations of OSs and versions)`
	`78`	`+ // boundary values are treated as "double" vs "integer" and failing is_int() check`
	`79`	`+ $isInt = is_int($value) \|\| $value === self::MIN_INT \|\| $value === self::MAX_INT;`
	`80`	`+ return $isInt && $value <= self::MAX_INT && $value >= self::MIN_INT ? $value : null;`
`78`	`81`	`}`
`79`	`82`
`80`	`83`	`/**`