Reverted #116 (now Executor::defaultFieldResolver checks for instanceof Closure vs is_callable again)

Author: vladar

src/Executor/Executor.php

@@ -965,7 +965,7 @@ public static function defaultFieldResolver($source, $args, $context, ResolveInf
             }
         }
 
-        return is_callable($property) ? $property($source, $args, $context, $info) : $property;
+        return $property instanceof \Closure ? $property($source, $args, $context, $info) : $property;
     }
 
     /**

tests/Executor/ResolveTest.php

@@ -44,13 +44,13 @@ public function testDefaultFunctionAccessesProperties()
     /**
      * @it default function calls methods
      */
-    public function testDefaultFunctionCallsMethods()
+    public function testDefaultFunctionCallsClosures()
     {
         $schema = $this->buildSchema(['type' => Type::string()]);
         $_secret = 'secretValue' . uniqid();
 
         $source = [
-            'test' => function () use ($_secret) {
+            'test' => function() use ($_secret) {
                 return $_secret;
             }
         ];
@@ -60,23 +60,6 @@ public function testDefaultFunctionCallsMethods()
         );
     }
 
-    /**
-     * @it default function calls callables
-     */
-    public function testDefaultFunctionCallsCallables()
-    {
-        $schema = $this->buildSchema(['type' => Type::string()]);
-        $_secret = 'secretValue' . uniqid();
-
-        $source = [
-            'test' => new ResolveTestCallableFixture($_secret)
-        ];
-        $this->assertEquals(
-            ['data' => ['test' => $_secret]],
-            GraphQL::execute($schema, '{ test }', $source)
-        );
-    }
-
     /**
      * @it default function passes args and context
      */
@@ -132,18 +115,3 @@ public function testUsesProvidedResolveFunction()
         );
     }
 }
-
-class ResolveTestCallableFixture
-{
-    private $value;
-
-    public function __construct($value)
-    {
-        $this->value = $value;
-    }
-
-    public function __invoke($root, $args, $context)
-    {
-        return $this->value;
-    }
-}