Simplify PHPStan error format configuration and shrink baseline (#1778)

Author: spawnia

.github/workflows/static-analysis.yml

@@ -37,4 +37,4 @@ jobs:
         uses: ramsey/composer-install@v2
 
       - name: Run a static analysis with phpstan/phpstan
-        run: vendor/bin/phpstan --error-format=checkstyle | cs2pr
+        run: vendor/bin/phpstan --error-format=github

Makefile

@@ -27,15 +27,19 @@ phpstan.neon:
 	printf "includes:\n  - phpstan.neon.dist" > phpstan.neon
 
 .PHONY: stan
-stan: ## Runs static analysis with phpstan
+stan: ## Runs static analysis with PHPStan
 	composer stan
 
+.PHONY: baseline
+baseline: ## Regenerate the PHPStan baseline
+	composer baseline
+
 .PHONY: test
-test: ## Runs tests with phpunit
+test: ## Runs tests with PHPUnit
 	composer test
 
 .PHONY: bench
-bench: ## Runs benchmarks with phpbench
+bench: ## Runs benchmarks with PHPBench
 	composer bench
 
 .PHONY: docs

phpstan-baseline.neon

@@ -1,11 +1,5 @@
 parameters:
 	ignoreErrors:
-		-
-			message: '#^Unable to resolve the template type TCloneable in call to static method GraphQL\\Language\\AST\\Node\:\:cloneValue\(\)$#'
-			identifier: argument.templateType
-			count: 1
-			path: src/Language/AST/Node.php
-
 		-
 			message: '#^Variable property access on TCloneable of TNode of GraphQL\\Language\\AST\\Node\.$#'
 			identifier: property.dynamicName
@@ -30,24 +24,12 @@ parameters:
 			count: 1
 			path: src/Type/Definition/InterfaceType.php
 
-		-
-			message: '#^Unable to resolve the template type T in call to static method GraphQL\\Type\\Schema\:\:resolveType\(\)$#'
-			identifier: argument.templateType
-			count: 1
-			path: src/Type/Definition/InterfaceType.php
-
 		-
 			message: '#^Property GraphQL\\Type\\Definition\\ObjectType\:\:\$interfaces \(array\<int, GraphQL\\Type\\Definition\\InterfaceType\>\) does not accept array\<int, GraphQL\\Type\\Definition\\Type\>\.$#'
 			identifier: assign.propertyType
 			count: 1
 			path: src/Type/Definition/ObjectType.php
 
-		-
-			message: '#^Unable to resolve the template type T in call to static method GraphQL\\Type\\Schema\:\:resolveType\(\)$#'
-			identifier: argument.templateType
-			count: 1
-			path: src/Type/Definition/ObjectType.php
-
 		-
 			message: '#^Method GraphQL\\Type\\Definition\\UnionType\:\:getTypes\(\) should return array\<int, GraphQL\\Type\\Definition\\ObjectType\> but returns array\<int, GraphQL\\Type\\Definition\\Type\>\.$#'
 			identifier: return.type
@@ -60,12 +42,6 @@ parameters:
 			count: 1
 			path: src/Type/Definition/UnionType.php
 
-		-
-			message: '#^Unable to resolve the template type T in call to static method GraphQL\\Type\\Schema\:\:resolveType\(\)$#'
-			identifier: argument.templateType
-			count: 1
-			path: src/Type/Definition/UnionType.php
-
 		-
 			message: '#^Method GraphQL\\Type\\Schema\:\:resolveType\(\) should return T of GraphQL\\Type\\Definition\\Type but returns \(callable&GraphQL\\Type\\Definition\\Type\)\|T of GraphQL\\Type\\Definition\\Type\.$#'
 			identifier: return.type

src/Language/AST/Node.php

@@ -72,7 +72,7 @@ protected static function cloneValue($value)
         if ($value instanceof self) {
             $cloned = clone $value;
             foreach (get_object_vars($cloned) as $prop => $propValue) {
-                $cloned->{$prop} = static::cloneValue($propValue);
+                $cloned->{$prop} = static::cloneValue($propValue); // @phpstan-ignore argument.templateType
             }
 
             return $cloned;

src/Type/Definition/ImplementingTypeImplementation.php

@@ -56,7 +56,7 @@ private function initializeInterfaces(): void
         }
 
         foreach ($interfaces as $interface) {
-            $this->interfaces[] = Schema::resolveType($interface);
+            $this->interfaces[] = Schema::resolveType($interface); // @phpstan-ignore argument.templateType
         }
     }
 

src/Type/Definition/UnionType.php

@@ -99,7 +99,7 @@ public function getTypes(): array
             }
 
             foreach ($types as $type) {
-                $this->types[] = Schema::resolveType($type);
+                $this->types[] = Schema::resolveType($type); // @phpstan-ignore argument.templateType
             }
         }