Allow iterable in PromiseAdapter::all()

Author: simPod

CHANGELOG.md

@@ -37,6 +37,7 @@ You can find and compare releases at the [GitHub release page](https://github.co
 - Always convert promises through `PromiseAdapter::convertThenable()` before calling `->then()` on them
 - Use `JSON_THROW_ON_ERROR` in `json_encode()`
 - Validate some internal invariants through `assert()`
+- `PromiseAdapter::all()` accepts `iterable`
 
 ### Added
 

src/Executor/Promise/Adapter/AmpPromiseAdapter.php

@@ -8,8 +8,10 @@
 use Amp\Promise as AmpPromise;
 use Amp\Success;
 use function array_replace;
+use function assert;
 use GraphQL\Executor\Promise\Promise;
 use GraphQL\Executor\Promise\PromiseAdapter;
+use function is_array;
 use Throwable;
 
 class AmpPromiseAdapter implements PromiseAdapter
@@ -77,8 +79,13 @@ public function createRejected(Throwable $reason): Promise
         return new Promise($promise, $this);
     }
 
-    public function all(array $promisesOrValues): Promise
+    public function all(iterable $promisesOrValues): Promise
     {
+        assert(
+            is_array($promisesOrValues),
+            'AmpPromiseAdapter::all(): Argument #1 ($promisesOrValues) must be of type array'
+        );
+
         /** @var array<AmpPromise<mixed>> $promises */
         $promises = [];
         foreach ($promisesOrValues as $key => $item) {

src/Executor/Promise/Adapter/ReactPromiseAdapter.php

@@ -52,8 +52,13 @@ public function createRejected(Throwable $reason): Promise
         return new Promise($promise, $this);
     }
 
-    public function all(array $promisesOrValues): Promise
+    public function all(iterable $promisesOrValues): Promise
     {
+        assert(
+            is_array($promisesOrValues),
+            'ReactPromiseAdapter::all(): Argument #1 ($promisesOrValues) must be of type array'
+        );
+
         // TODO: rework with generators when PHP minimum required version is changed to 5.5+
 
         foreach ($promisesOrValues as &$promiseOrValue) {

src/Executor/Promise/Adapter/SyncPromiseAdapter.php

@@ -2,12 +2,14 @@
 
 namespace GraphQL\Executor\Promise\Adapter;
 
+use function assert;
 use function count;
 use GraphQL\Deferred;
 use GraphQL\Error\InvariantViolation;
 use GraphQL\Executor\Promise\Promise;
 use GraphQL\Executor\Promise\PromiseAdapter;
 use GraphQL\Utils\Utils;
+use function is_array;
 use Throwable;
 
 /**
@@ -72,8 +74,13 @@ public function createRejected(Throwable $reason): Promise
         return new Promise($promise->reject($reason), $this);
     }
 
-    public function all(array $promisesOrValues): Promise
+    public function all(iterable $promisesOrValues): Promise
     {
+        assert(
+            is_array($promisesOrValues),
+            'SyncPromiseAdapter::all(): Argument #1 ($promisesOrValues) must be of type array'
+        );
+
         $all = new SyncPromise();
 
         $total = count($promisesOrValues);

src/Executor/Promise/PromiseAdapter.php

@@ -63,12 +63,12 @@ public function createFulfilled($value = null): Promise;
     public function createRejected(Throwable $reason): Promise;
 
     /**
-     * Given an array of promises (or values), returns a promise that is fulfilled when all the
-     * items in the array are fulfilled.
+     * Given an iterable of promises (or values), returns a promise that is fulfilled when all the
+     * items in the iterable are fulfilled.
      *
-     * @param array<Promise|mixed> $promisesOrValues
+     * @param iterable<Promise|mixed> $promisesOrValues
      *
      * @api
      */
-    public function all(array $promisesOrValues): Promise;
+    public function all(iterable $promisesOrValues): Promise;
 }