Replace phpcs with php-cs-fixer (#1044)

Author: spawnia

.gitattributes

@@ -1,17 +1,18 @@
 # Set the default behavior, in case people don't have core.autocrlf set.
 * text eol=lf
-/.github export-ignore
-/benchmarks export-ignore
-/tests export-ignore
-/examples export-ignore
+
+.github export-ignore
+benchmarks export-ignore
+tests export-ignore
+examples export-ignore
 .codecov.yml export-ignore
 .gitattributes export-ignore
 .gitignore export-ignore
 CONTRIBUTING.md export-ignore
 generate-class-reference.php export-ignore
 mkdocs.yml export-ignore
 phpbench.json export-ignore
-phpcs.xml.dist export-ignore
+.php-cs-fixer.php export-ignore
 phpstan.neon.dist export-ignore
 phpstan-baseline.neon export-ignore
 phpunit.xml.dist export-ignore

.github/workflows/autoformat.yml

@@ -0,0 +1,63 @@
+name: "Autoformat"
+on:
+  push:
+
+jobs:
+  composer-normalize:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          ref: ${{ github.head_ref }}
+
+      - uses: shivammathur/setup-php@v2
+        with:
+          coverage: none
+          extensions: mbstring
+          php-version: 7.4
+
+      - run: composer install --no-interaction --no-progress --no-suggest
+
+      - run: composer normalize
+
+      - uses: stefanzweifel/git-auto-commit-action@v4
+        with:
+          commit_message: Normalize composer.json
+
+  prettier:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          ref: ${{ github.head_ref }}
+
+      - uses: creyD/[email protected]
+        with:
+          prettier_options: --write --tab-width=2 *.md **/*.md
+          branch: ${{ github.head_ref }}
+          commit_message: Prettify docs
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+  php-cs-fixer:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          ref: ${{ github.head_ref }}
+
+      - uses: shivammathur/setup-php@v2
+        with:
+          coverage: none
+          extensions: mbstring
+          php-version: 7.4
+
+      - run: composer install --no-interaction --no-progress --no-suggest
+
+      - run: vendor/bin/php-cs-fixer fix
+
+      - run: git pull
+
+      - uses: stefanzweifel/git-auto-commit-action@v4
+        with:
+          commit_message: Apply php-cs-fixer changes

.github/workflows/coding-standards.yml

@@ -1,8 +1,7 @@
-.phpcs-cache
 .phpunit.result.cache
+.php-cs-fixer.cache
 composer.lock
 composer.phar
-phpcs.xml
 phpstan.neon
-vendor/
-/.idea
+vendor
+.idea

.github/workflows/format.yml

@@ -0,0 +1,16 @@
+<?php declare(strict_types=1);
+
+use function MLL\PhpCsFixerConfig\config;
+
+$finder = PhpCsFixer\Finder::create()
+    ->notPath('vendor')
+    ->in(__DIR__)
+    ->name('*.php')
+    ->ignoreDotFiles(true)
+    ->ignoreVCS(true);
+
+return config($finder, [
+    'no_superfluous_phpdoc_tags' => [
+        'allow_mixed' => true,
+    ],
+]);

.gitignore

@@ -41,26 +41,20 @@ we instead use [the PHP native `nowdoc` syntax](https://www.php.net/manual/en/la
 If the string contents are in a specific grammar, use an appropriate tag such as `GRAPHQL`, `PHP` or `JSON`:
 
 ```php
-        self::assertSomePrintedOutputExactlyMatches(
-            <<<'GRAPHQL'
-            type Foo {
-              bar: Baz
-            }
-
-            GRAPHQL,
-            $output
-        );
+self::assertSomePrintedOutputExactlyMatches(
+    <<<'GRAPHQL'
+    type Foo {
+      bar: Baz
+    }
+
+    GRAPHQL,
+    $output
+);
 ```
 
 ## Coding Standard
 
-We check and fix the coding standard with [PHP_CodeSniffer](https://github.com/squizlabs/PHP_CodeSniffer).
-
-Run the inspections:
-
-```sh
-composer lint
-```
+We format the code automatically with [php-cs-fixer](https://github.com/friendsofphp/php-cs-fixer).
 
 Apply automatic code style fixes:
 

.php-cs-fixer.php

@@ -5,7 +5,6 @@
 namespace GraphQL\Benchmarks;
 
 use GraphQL\Utils\BuildSchema;
-
 use function range;
 
 /**

CONTRIBUTING.md

@@ -37,7 +37,7 @@ public function setUp(): void
 
         $this->schema = $this->schemaGenerator->buildSchema();
 
-        $queryBuilder     = new QueryGenerator($this->schema, 0.05);
+        $queryBuilder = new QueryGenerator($this->schema, 0.05);
         $this->smallQuery = $queryBuilder->buildQuery();
     }
 

benchmarks/BuildSchemaBench.php

@@ -33,6 +33,6 @@ public function benchIntrospectionQuery(): void
 
         do {
             $token = $lexer->advance();
-        } while ($token->kind !== Token::EOF);
+        } while (Token::EOF !== $token->kind);
     }
 }