Server: do not raise an error when variables are passed as empty string (#156)

Author: vladar

src/Server/OperationParams.php

@@ -71,6 +71,10 @@ public static function create(array $params, $readonly = false)
             'variables' => null
         ];
 
+        if ($params['variables'] === "") {
+            $params['variables'] = null;
+        }
+
         if (is_string($params['variables'])) {
             $tmp = json_decode($params['variables'], true);
             if (!json_last_error()) {

tests/Server/RequestValidationTest.php

@@ -99,6 +99,26 @@ public function testFailsWhenOperationParameterIsNotString()
         );
     }
 
+    /**
+     * @see https://github.com/webonyx/graphql-php/issues/156
+     */
+    public function testIgnoresNullAndEmptyStringVariables()
+    {
+        $query = '{my q}';
+        $parsedBody = OperationParams::create([
+            'query' => $query,
+            'variables' => null
+        ]);
+        $this->assertValid($parsedBody);
+
+        $variables = "";
+        $parsedBody = OperationParams::create([
+            'query' => $query,
+            'variables' => $variables
+        ]);
+        $this->assertValid($parsedBody);
+    }
+
     public function testFailsWhenVariablesParameterIsNotObject()
     {
         $parsedBody = OperationParams::create([