Increase PHPStan analysis level to 8 (#1059)

Author: spawnia

CHANGELOG.md

@@ -38,6 +38,8 @@ You can find and compare releases at the [GitHub release page](https://github.co
 - Use `JSON_THROW_ON_ERROR` in `json_encode()`
 - Validate some internal invariants through `assert()`
 - `PromiseAdapter::all()` accepts `iterable`
+- Throw if `Introspection::fromSchema()` returns no data
+- Reorganize abstract class `ASTValidationContext` to interface `ValidationContext`
 
 ### Added
 
@@ -69,6 +71,7 @@ You can find and compare releases at the [GitHub release page](https://github.co
 - Fix printing of empty types (#940)
 - Clone `NodeList` in `Node::cloneDeep()`
 - Calling `Schema::getType()` on a schema built from SDL returns `null` for unknown types (#1068)
+- Avoid crash on typeless inline fragment when using `QueryComplexity` rule
 
 ### Removed
 
@@ -105,6 +108,7 @@ You can find and compare releases at the [GitHub release page](https://github.co
 - Remove option `commentDescriptions` from `BuildSchema::buildAST()`, `BuildSchema::build()` and `Printer::doPrint()`
 - Remove parameter `$options` from `ASTDefinitionBuilder`
 - Remove `FieldDefinition::create()` in favor of `new FieldDefinition()`
+- Remove `GraphQL\Exception\InvalidArgument`
 
 ## 14.11.5
 

benchmarks/Utils/QueryGenerator.php

@@ -15,7 +15,6 @@
 use GraphQL\Type\Definition\ObjectType;
 use GraphQL\Type\Definition\Type;
 use GraphQL\Type\Schema;
-use GraphQL\Utils\Utils;
 use function max;
 use function round;
 
@@ -31,7 +30,7 @@ public function __construct(Schema $schema, float $percentOfLeafFields)
     {
         $this->schema = $schema;
 
-        Utils::invariant(0 < $percentOfLeafFields && $percentOfLeafFields <= 1);
+        assert(0 < $percentOfLeafFields && $percentOfLeafFields <= 1);
 
         $totalFields = 0;
         foreach ($schema->getTypeMap() as $type) {
@@ -47,6 +46,7 @@ public function __construct(Schema $schema, float $percentOfLeafFields)
     public function buildQuery(): string
     {
         $queryType = $this->schema->getQueryType();
+        assert($queryType instanceof ObjectType);
 
         $ast = new DocumentNode([
             'definitions' => new NodeList([

docs/security.md

@@ -42,9 +42,7 @@ $type = new ObjectType([
                     'defaultValue' => 10
                 ]
             ],
-            'complexity' => function($childrenComplexity, $args) {
-                return $childrenComplexity * $args['limit'];
-            }
+            'complexity' => fn (int $childrenComplexity, array $args): int => $childrenComplexity * $args['limit'],
         ]
     ]
 ]);

examples/01-blog/Blog/Types.php

@@ -107,7 +107,10 @@ private static function byClassName(string $classname): Type
     {
         $parts = explode('\\', $classname);
 
-        $cacheName = strtolower(preg_replace('~Type$~', '', $parts[count($parts) - 1]));
+        $withoutTypePrefix = preg_replace('~Type$~', '', $parts[count($parts) - 1]);
+        assert(is_string($withoutTypePrefix), 'regex is statically known to be correct');
+
+        $cacheName = strtolower($withoutTypePrefix);
 
         if (! isset(self::$types[$cacheName])) {
             return self::$types[$cacheName] = new $classname();

examples/01-blog/graphql.php

@@ -29,7 +29,9 @@
 
     // Prepare context that will be available in all field resolvers (as 3rd argument):
     $appContext = new AppContext();
-    $appContext->viewer = DataSource::findUser(1); // simulated "currently logged-in user"
+    $currentlyLoggedInUser = DataSource::findUser(1);
+    assert(null !== $currentlyLoggedInUser);
+    $appContext->viewer = $currentlyLoggedInUser;
     $appContext->rootUrl = 'http://localhost:8080';
     $appContext->request = $_REQUEST;
 

generate-class-reference.php

@@ -175,7 +175,11 @@ function unwrapDocblock(string $docBlock): string
     }
 
     $content = preg_replace('~([\r\n]) \* (.*)~i', '$1$2', $docBlock); // strip *
+    assert(is_string($content), 'regex is statically known to be valid');
+
     $content = preg_replace('~([\r\n])[\* ]+([\r\n])~i', '$1$2', $content); // strip single-liner *
+    assert(is_string($content), 'regex is statically known to be valid');
+
     $content = substr($content, 3); // strip leading /**
     $content = substr($content, 0, -2); // strip trailing */
 

phpstan-baseline.neon

@@ -75,11 +75,6 @@ parameters:
 			count: 1
 			path: src/Language/Printer.php
 
-		-
-			message: "#^Strict comparison using \\=\\=\\= between mixed and null will always evaluate to false\\.$#"
-			count: 1
-			path: src/Language/Visitor.php
-
 		-
 			message: "#^Variable property access on GraphQL\\\\Language\\\\AST\\\\Node\\.$#"
 			count: 1

phpstan.neon.dist

@@ -1,6 +1,6 @@
 parameters:
     # TODO increase to max
-    level: 7
+    level: 8
 
     paths:
         - benchmarks

src/Error/FormattedError.php

@@ -64,13 +64,15 @@ public static function printError(Error $error): string
         $nodes = $error->nodes;
         if (isset($nodes) && count($nodes) > 0) {
             foreach ($nodes as $node) {
-                if (isset($node->loc->source)) {
-                    $location = $node->loc;
+                $location = $node->loc;
+                if (isset($location)) {
                     $source = $location->source;
-                    $printedLocations[] = self::highlightSourceAtLocation(
-                        $source,
-                        $source->getLocation($location->start)
-                    );
+                    if (isset($source)) {
+                        $printedLocations[] = self::highlightSourceAtLocation(
+                            $source,
+                            $source->getLocation($location->start)
+                        );
+                    }
                 }
             }
         } elseif (null !== $error->getSource() && 0 !== count($error->getLocations())) {

src/Error/InvariantViolation.php

@@ -11,8 +11,4 @@
  */
 class InvariantViolation extends LogicException
 {
-    public static function shouldNotHappen(): self
-    {
-        return new self('This should not have happened');
-    }
 }