Switch to PHPStan level 4 (#1013)

Author: spawnia

phpstan.neon.dist

@@ -1,6 +1,6 @@
 parameters:
     # TODO increase to max
-    level: 3
+    level: 4
 
     inferPrivatePropertyTypeFromConstructor: true
 
@@ -37,6 +37,10 @@ parameters:
         # TODO convert to less magical code
         - "~Variable method call on static\\(GraphQL\\\\Server\\\\ServerConfig\\)~"
 
+        # PHPStan does not play nicely with markTestSkipped()
+        - message: "~Unreachable statement - code above always terminates~"
+          path: tests
+
 includes:
     - phpstan-baseline.neon
 

tests/Executor/Promise/SyncPromiseTest.php renamed to tests/Executor/Promise/SyncPromiseTestTestCaseBase.php

@@ -12,7 +12,7 @@
 
 use function uniqid;
 
-class SyncPromiseTest extends TestCaseBase
+class SyncPromiseTestTestCaseBase extends TestCaseBase
 {
     public function getFulfilledPromiseResolveData()
     {

tests/Language/ParserTest.php

@@ -11,7 +11,6 @@
 use GraphQL\Language\AST\Node;
 use GraphQL\Language\AST\NodeKind;
 use GraphQL\Language\AST\NodeList;
-use GraphQL\Language\AST\ObjectTypeDefinitionNode;
 use GraphQL\Language\AST\OperationDefinitionNode;
 use GraphQL\Language\AST\SelectionSetNode;
 use GraphQL\Language\AST\StringValueNode;
@@ -729,38 +728,38 @@ public function testParsesNestedTypes(): void
 
     public function testPartiallyParsesSource(): void
     {
-        self::assertInstanceOf(
-            NameNode::class,
-            Parser::name('Foo')
+        self::assertSame(
+            'Foo',
+            Parser::name('Foo')->value
         );
 
-        self::assertInstanceOf(
-            ObjectTypeDefinitionNode::class,
-            Parser::objectTypeDefinition('type Foo { name: String }')
+        self::assertSame(
+            'Foo',
+            Parser::objectTypeDefinition('type Foo { name: String }')->name->value
         );
 
         self::assertInstanceOf(
             VariableNode::class,
             Parser::valueLiteral('$foo')
         );
 
-        self::assertInstanceOf(
-            NodeList::class,
+        self::assertCount(
+            1,
             Parser::argumentsDefinition('(foo: Int!)')
         );
 
-        self::assertInstanceOf(
-            NodeList::class,
+        self::assertCount(
+            2,
             Parser::directiveLocations('| INPUT_OBJECT | OBJECT')
         );
 
-        self::assertInstanceOf(
-            NodeList::class,
+        self::assertCount(
+            2,
             Parser::implementsInterfaces('implements Foo & Bar')
         );
 
-        self::assertInstanceOf(
-            NodeList::class,
+        self::assertCount(
+            2,
             Parser::unionMemberTypes('= | Foo | Bar')
         );
 

tests/TestCaseBase.php

@@ -8,8 +8,12 @@
 
 abstract class TestCaseBase extends TestCase
 {
+    /**
+     * Useful to test code with no observable behaviour other than not crashing.
+     */
     public static function assertDidNotCrash(): void
     {
+        // @phpstan-ignore-next-line this truism is required to prevent a PHPUnit warning
         self::assertTrue(true);
     }
 }