Skip to content

Commit e6c5712

Browse files
simPodspawnia
authored andcommitted
Resolve ReactPromise deprecations
1 parent f7a9c62 commit e6c5712

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

tests/Executor/Promise/ReactPromiseAdapterTest.php

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,11 @@
77
use PHPUnit\Framework\TestCase;
88
use React\Promise\Deferred;
99
use React\Promise\FulfilledPromise;
10-
use React\Promise\LazyPromise;
1110
use React\Promise\Promise;
1211
use React\Promise\Promise as ReactPromise;
12+
use function React\Promise\reject;
1313
use React\Promise\RejectedPromise;
14+
use function React\Promise\resolve;
1415
use stdClass;
1516

1617
/**
@@ -26,12 +27,8 @@ public function testIsThenableReturnsTrueWhenAReactPromiseIsGiven(): void
2627
$reactAdapter->isThenable(new ReactPromise(static function (): void {
2728
}))
2829
);
29-
self::assertTrue($reactAdapter->isThenable(new FulfilledPromise()));
30-
self::assertTrue($reactAdapter->isThenable(new RejectedPromise()));
31-
self::assertTrue(
32-
$reactAdapter->isThenable(new LazyPromise(static function (): void {
33-
}))
34-
);
30+
self::assertTrue($reactAdapter->isThenable(resolve()));
31+
self::assertTrue($reactAdapter->isThenable(reject()));
3532
self::assertFalse($reactAdapter->isThenable(false));
3633
self::assertFalse($reactAdapter->isThenable(true));
3734
self::assertFalse($reactAdapter->isThenable(1));
@@ -45,7 +42,7 @@ public function testIsThenableReturnsTrueWhenAReactPromiseIsGiven(): void
4542
public function testConvertsReactPromisesToGraphQlOnes(): void
4643
{
4744
$reactAdapter = new ReactPromiseAdapter();
48-
$reactPromise = new FulfilledPromise(1);
45+
$reactPromise = resolve(1);
4946

5047
$promise = $reactAdapter->convertThenable($reactPromise);
5148

@@ -55,7 +52,7 @@ public function testConvertsReactPromisesToGraphQlOnes(): void
5552
public function testThen(): void
5653
{
5754
$reactAdapter = new ReactPromiseAdapter();
58-
$reactPromise = new FulfilledPromise(1);
55+
$reactPromise = resolve(1);
5956
$promise = $reactAdapter->convertThenable($reactPromise);
6057

6158
$result = null;
@@ -128,7 +125,7 @@ static function ($error) use (&$exception): void {
128125
public function testAll(): void
129126
{
130127
$reactAdapter = new ReactPromiseAdapter();
131-
$promises = [new FulfilledPromise(1), new FulfilledPromise(2), new FulfilledPromise(3)];
128+
$promises = [resolve(1), resolve(2), resolve(3)];
132129

133130
$allPromise = $reactAdapter->all($promises);
134131

@@ -147,7 +144,7 @@ public function testAllShouldPreserveTheOrderOfTheArrayWhenResolvingAsyncPromise
147144
{
148145
$reactAdapter = new ReactPromiseAdapter();
149146
$deferred = new Deferred();
150-
$promises = [new FulfilledPromise(1), $deferred->promise(), new FulfilledPromise(3)];
147+
$promises = [resolve(1), $deferred->promise(), resolve(3)];
151148
$result = null;
152149

153150
$reactAdapter->all($promises)->then(static function ($values) use (&$result): void {

0 commit comments

Comments
 (0)