Fix problems found by the newest version of PHPStan (#1084)

Author: vhenzl

src/Language/Parser.php

@@ -605,7 +605,6 @@ private function parseOperationType(): string
      */
     private function parseVariableDefinitions(): NodeList
     {
-        // @phpstan-ignore-next-line generic type of empty NodeList is not initialized
         return $this->peek(Token::PAREN_L)
             ? $this->many(
                 Token::PAREN_L,
@@ -703,7 +702,6 @@ private function parseArguments(bool $isConst): NodeList
             ? fn (): ArgumentNode => $this->parseConstArgument()
             : fn (): ArgumentNode => $this->parseArgument();
 
-        // @phpstan-ignore-next-line generic type of empty NodeList is not initialized
         return $this->peek(Token::PAREN_L)
             ? $this->many(Token::PAREN_L, $parseFn, Token::PAREN_R)
             : new NodeList([]);
@@ -1224,7 +1222,6 @@ private function parseFieldDefinition(): FieldDefinitionNode
      */
     private function parseArgumentsDefinition(): NodeList
     {
-        // @phpstan-ignore-next-line generic type of empty NodeList is not initialized
         return $this->peek(Token::PAREN_L)
             ? $this->many(
                 Token::PAREN_L,
@@ -1340,7 +1337,6 @@ private function parseEnumTypeDefinition(): EnumTypeDefinitionNode
      */
     private function parseEnumValuesDefinition(): NodeList
     {
-        // @phpstan-ignore-next-line generic type of empty NodeList is not initialized
         return $this->peek(Token::BRACE_L)
             ? $this->many(
                 Token::BRACE_L,
@@ -1388,7 +1384,6 @@ private function parseInputObjectTypeDefinition(): InputObjectTypeDefinitionNode
      */
     private function parseInputFieldsDefinition(): NodeList
     {
-        // @phpstan-ignore-next-line generic type of empty NodeList is not initialized
         return $this->peek(Token::BRACE_L)
             ? $this->many(
                 Token::BRACE_L,

src/Language/Printer.php

@@ -218,7 +218,6 @@ protected function p(?Node $node, bool $isDescription = false): string
                 return 'fragment ' . $this->p($node->name)
                     . $this->wrap(
                         '(',
-                        // @phpstan-ignore-next-line generic type of empty NodeList is not recognized
                         $this->printList($node->variableDefinitions ?? new NodeList([]), ', '),
                         ')'
                     )

src/Validator/Rules/QueryComplexity.php

@@ -49,8 +49,6 @@ public function __construct(int $maxQueryComplexity)
     public function getVisitor(QueryValidationContext $context): array
     {
         $this->context = $context;
-
-        // @phpstan-ignore-next-line Initializing with an empty array does not set the generic type
         $this->variableDefs = new NodeList([]);
         $this->fieldNodeAndDefs = new ArrayObject();
 

tests/Language/NodeListTest.php

@@ -51,6 +51,7 @@ public function testThrowsOnInvalidArrays(): void
 
     public function testPushNodes(): void
     {
+        /** @var NodeList<NameNode> $nodeList */
         $nodeList = new NodeList([]);
         self::assertCount(0, $nodeList);
 

tests/Language/VisitorTest.php

@@ -236,7 +236,6 @@ public function testAllowsEditingRootNodeOnEnterAndLeave(): void
                     'enter' => function (DocumentNode $node) use ($ast): DocumentNode {
                         $this->checkVisitorFnArgs($ast, func_get_args());
                         $tmp = clone $node;
-                        // @phpstan-ignore-next-line generic type of empty NodeList is not initialized
                         $tmp->definitions = new NodeList([]);
                         $tmp->didEnter = true;