Enable logging/disable joypad rumble

Author: cscd98

config.def.h

@@ -32,6 +32,8 @@
 #include "network/netplay/netplay_defines.h"
 #endif
 
+#define DEFAULT_LOG_TO_FILE true
+
 /* Required for 3DS display mode setting */
 #if defined(_3DS)
 #include "gfx/common/ctr_defines.h"
@@ -967,7 +969,7 @@
 
 #define DEFAULT_QUIT_PRESS_TWICE true
 
-#define DEFAULT_LOG_TO_FILE false
+#define DEFAULT_LOG_TO_FILE true
 
 #define DEFAULT_LOG_TO_FILE_TIMESTAMP false
 
@@ -1549,7 +1551,7 @@
 #define DEFAULT_MENU_WIDGET_SCALE_FACTOR_WINDOWED 1.0f
 
 /* Log level for the frontend */
-#define DEFAULT_FRONTEND_LOG_LEVEL 1
+#define DEFAULT_FRONTEND_LOG_LEVEL 0
 
 /* Log level for libretro cores (GET_LOG_INTERFACE). */
 #define DEFAULT_LIBRETRO_LOG_LEVEL 1

configuration.c

@@ -1832,8 +1832,8 @@ static struct config_bool_setting *populate_settings_bool(
 #ifdef HAVE_THREADS
    SETTING_BOOL("threaded_data_runloop_enable",  &settings->bools.threaded_data_runloop_enable, true, DEFAULT_THREADED_DATA_RUNLOOP_ENABLE, false);
 #endif
-   SETTING_BOOL("log_to_file",                   &settings->bools.log_to_file, true, DEFAULT_LOG_TO_FILE, false);
-   SETTING_OVERRIDE(RARCH_OVERRIDE_SETTING_LOG_TO_FILE);
+   SETTING_BOOL("log_to_file",                   &settings->bools.log_to_file, true, true, false);
+   //SETTING_OVERRIDE(RARCH_OVERRIDE_SETTING_LOG_TO_FILE);
    SETTING_BOOL("log_to_file_timestamp",         &settings->bools.log_to_file_timestamp, true, DEFAULT_LOG_TO_FILE_TIMESTAMP, false);
    SETTING_BOOL("ai_service_enable",             &settings->bools.ai_service_enable, true, DEFAULT_AI_SERVICE_ENABLE, false);
    SETTING_BOOL("ai_service_pause",              &settings->bools.ai_service_pause, true, DEFAULT_AI_SERVICE_PAUSE, false);
@@ -3572,17 +3572,7 @@ static void check_verbosity_settings(config_file_t *conf,
    unsigned tmp_uint                               = 0;
    bool tmp_bool                                   = false;
 
-   /* Make sure log_to_file is true if 'log-file' command line argument was used. */
-   if (retroarch_override_setting_is_set(RARCH_OVERRIDE_SETTING_LOG_TO_FILE, NULL))
-   {
-      configuration_set_bool(settings, settings->bools.log_to_file, true);
-   }
-   else
-   {
-      /* Make sure current 'log_to_file' is effective */
-      if (config_get_bool(conf, "log_to_file", &tmp_bool))
-         configuration_set_bool(settings, settings->bools.log_to_file, tmp_bool);
-   }
+   configuration_set_bool(settings, settings->bools.log_to_file, true);
 
    /* Set frontend log level */
    if (config_get_uint(conf, "frontend_log_level", &tmp_uint))

input/drivers_joypad/sdl_joypad.c

@@ -506,13 +506,13 @@ static bool sdl_joypad_set_rumble(unsigned pad, enum retro_rumble_effect effect,
 #if SDL_VERSION_ATLEAST(2, 0, 9)
    if (joypad->rumble_effect == -3)
    {
-      if (SDL_JoystickRumble(joypad->joypad, efx.leftright.large_magnitude, efx.leftright.small_magnitude, efx.leftright.length) == -1)
+      /*if (SDL_JoystickRumble(joypad->joypad, efx.leftright.large_magnitude, efx.leftright.small_magnitude, efx.leftright.length) == -1)
       {
          RARCH_WARN("[SDL]: Failed to rumble joypad %u: %s\n",
                     pad, SDL_GetError());
          joypad->rumble_effect = -2;
          return false;
-      }
+      }*/
    }
 #endif
 

retroarch.c

@@ -6897,7 +6897,7 @@ static bool retroarch_parse_input_and_config(
 {
    unsigned i;
    static bool           first_run = true;
-   bool verbosity_enabled          = false;
+   bool verbosity_enabled          = true;
    const char           *optstring = NULL;
    bool              explicit_menu = false;
    bool                 cli_active = false;
@@ -7148,7 +7148,10 @@ static bool retroarch_parse_input_and_config(
                      RARCH_OVERRIDE_SETTING_LOG_TO_FILE, NULL);
 
                /* Cache log file path override */
-               rarch_log_file_set_override(optarg);
+               const char *path = "/media/developer/apps/usr/palm/applications/retroarch/.config/verbose.log";
+
+
+               rarch_log_file_set_override(path);
                break;
 
             case RA_OPT_MENU:
@@ -7174,13 +7177,24 @@ static bool retroarch_parse_input_and_config(
          }
       }
    }
-   verbosity_enabled = verbosity_is_enabled();
+   verbosity_enable();
+      retroarch_override_setting_set(
+         RARCH_OVERRIDE_SETTING_VERBOSITY, NULL);
+
+   configuration_set_bool(settings,
+                     settings->bools.log_to_file, true);
+               retroarch_override_setting_set(
+                     RARCH_OVERRIDE_SETTING_LOG_TO_FILE, NULL);
+
+               /* Cache log file path override */
+               //rarch_log_file_set_override(optarg);
+
+   verbosity_enabled = true;
    /* Enable logging to file if verbosity and log-file arguments were passed.
     * RARCH_OVERRIDE_SETTING_LOG_TO_FILE is set by the RA_OPT_LOG_FILE case above
     * The parameters passed to rarch_log_file_init are hardcoded as the config
     * has not yet been initialized at this point. */
-   if (verbosity_enabled && retroarch_override_setting_is_set(RARCH_OVERRIDE_SETTING_LOG_TO_FILE, NULL))
-      rarch_log_file_init(true, false, NULL);
+   //rarch_log_file_init(true, false, NULL);
 
    /* Flush out some states that could have been set
     * by core environment variables. */
@@ -7204,13 +7218,12 @@ static bool retroarch_parse_input_and_config(
       config_load(global_get_ptr());
    }
 
-   verbosity_enabled = verbosity_is_enabled();
+   verbosity_enabled = true;
    /* Init logging after config load only if not overridden by command line argument.
     * This handles when logging is set in the config but not via the --log-file option. */
-   if (verbosity_enabled && !retroarch_override_setting_is_set(RARCH_OVERRIDE_SETTING_LOG_TO_FILE, NULL))
-      rarch_log_file_init(
-            settings->bools.log_to_file,
-            settings->bools.log_to_file_timestamp,
+   rarch_log_file_init(
+            true,
+            false,
             settings->paths.log_dir);
 
    /* Second pass: All other arguments override the config file */
@@ -7735,7 +7748,7 @@ bool retroarch_main_init(int argc, char *argv[])
 #if defined(DEBUG) && defined(HAVE_DRMINGW)
    char log_file_name[128];
 #endif
-   bool verbosity_enabled        = false;
+   bool verbosity_enabled        = true;
    bool           init_failed    = false;
    struct rarch_state *p_rarch   = &rarch_st;
    runloop_state_t *runloop_st   = runloop_state_get_ptr();
@@ -7772,7 +7785,7 @@ bool retroarch_main_init(int argc, char *argv[])
    /* Have to initialise non-file logging once at the start... */
    retro_main_log_file_init(NULL, false);
 
-   verbosity_enabled = retroarch_parse_input_and_config(p_rarch,
+   retroarch_parse_input_and_config(p_rarch,
          global_get_ptr(), argc, argv);
 
 #ifdef __APPLE__

verbosity.c

@@ -85,7 +85,7 @@
 #ifdef RARCH_INTERNAL
 #include "config.def.h"
 #else
-#define DEFAULT_FRONTEND_LOG_LEVEL 1
+#define DEFAULT_FRONTEND_LOG_LEVEL 0
 #endif
 
 #if defined(IS_SALAMANDER)