fix: fail on error and fail on warning (#275)

* fix: fail on error and fail on warning

* chore: update deps

* chore: update lockfile

Author: ricardogobbosouza

package-lock.json

@@ -57,34 +57,34 @@
     "schema-utils": "^4.3.0"
   },
   "devDependencies": {
-    "@babel/cli": "^7.26.4",
-    "@babel/core": "^7.26.7",
-    "@babel/preset-env": "^7.26.7",
-    "@commitlint/cli": "^19.7.1",
-    "@commitlint/config-conventional": "^19.7.1",
+    "@babel/cli": "^7.27.0",
+    "@babel/core": "^7.26.10",
+    "@babel/preset-env": "^7.26.9",
+    "@commitlint/cli": "^19.8.0",
+    "@commitlint/config-conventional": "^19.8.0",
     "@types/fs-extra": "^11.0.4",
     "@types/micromatch": "^4.0.9",
-    "@types/node": "^22.13.1",
+    "@types/node": "^22.14.0",
     "@types/normalize-path": "^3.0.2",
     "@types/webpack": "^5.28.5",
     "@webpack-contrib/eslint-config-webpack": "^3.0.0",
     "babel-jest": "^29.7.0",
     "chokidar": "^4.0.3",
     "cross-env": "^7.0.3",
-    "cspell": "^8.17.3",
+    "cspell": "^8.18.1",
     "del": "^8.0.0",
     "del-cli": "^6.0.0",
-    "eslint": "^9.19.0",
-    "eslint-config-prettier": "^10.0.1",
+    "eslint": "^9.24.0",
+    "eslint-config-prettier": "^10.1.2",
     "fs-extra": "^11.3.0",
     "husky": "^9.1.7",
     "jest": "^29.7.0",
-    "lint-staged": "^15.4.3",
+    "lint-staged": "^15.5.0",
     "npm-run-all": "^4.1.5",
-    "prettier": "^3.4.2",
+    "prettier": "^3.5.3",
     "standard-version": "^9.5.0",
-    "typescript": "^5.7.3",
-    "webpack": "^5.97.1"
+    "typescript": "^5.8.3",
+    "webpack": "^5.99.5"
   },
   "keywords": [
     "eslint",

package.json

@@ -150,29 +150,34 @@ class ESLintWebpackPlugin {
       });
 
       // await and interpret results
-      compilation.hooks.additionalAssets.tapPromise(this.key, processResults);
-
-      async function processResults() {
-        const { errors, warnings, generateReportAsset } = await report();
-
-        if (warnings && !options.failOnWarning) {
-          // @ts-ignore
-          compilation.warnings.push(warnings);
-        } else if (warnings) {
-          // @ts-ignore
-          compilation.errors.push(warnings);
-        }
-
-        if (errors && !options.failOnError) {
-          // @ts-ignore
-          compilation.warnings.push(errors);
-        } else if (errors) {
-          // @ts-ignore
-          compilation.errors.push(errors);
-        }
-
-        if (generateReportAsset) await generateReportAsset(compilation);
-      }
+      compilation.hooks.additionalAssets.tapAsync(
+        this.key,
+        async function (callback) {
+          const { errors, warnings, generateReportAsset } = await report();
+
+          if (warnings) {
+            // @ts-ignore
+            compilation.warnings.push(warnings);
+          }
+
+          if (errors) {
+            // @ts-ignore
+            compilation.errors.push(errors);
+          }
+
+          if (generateReportAsset) {
+            await generateReportAsset(compilation);
+          }
+
+         if (warnings && options.failOnWarning) {
+           callback(warnings);
+         } else if (errors && options.failOnError) {
+           callback(errors);
+         } else {
+           callback();
+         }
+        },
+      );
     });
   }
 

src/index.js

@@ -4,21 +4,20 @@ describe('fail on error', () => {
   it('should emits errors', async () => {
     const compiler = pack('error', { failOnError: true });
 
-    const stats = await compiler.runAsync();
-    expect(stats.hasErrors()).toBe(true);
+    await expect(compiler.runAsync()).rejects.toThrow('error');
   });
 
   it('should emit warnings when disabled', async () => {
     const compiler = pack('error', { failOnError: false });
 
     const stats = await compiler.runAsync();
-    expect(stats.hasErrors()).toBe(false);
-    expect(stats.hasWarnings()).toBe(true);
+    expect(stats.hasErrors()).toBe(true);
   });
 
   it('should correctly identifies a success', async () => {
     const compiler = pack('good', { failOnError: true });
 
-    await compiler.runAsync();
+    const stats = await compiler.runAsync();
+    expect(stats.hasErrors()).toBe(false);
   });
 });

test/fail-on-error.test.js

@@ -4,8 +4,7 @@ describe('fail on warning', () => {
   it('should emits errors', async () => {
     const compiler = pack('warn', { failOnWarning: true });
 
-    const stats = await compiler.runAsync();
-    expect(stats.hasErrors()).toBe(true);
+    await expect(compiler.runAsync()).rejects.toThrow('warning');
   });
 
   it('should correctly identifies a success', async () => {

test/fail-on-warning.test.js

@@ -41,8 +41,7 @@ describe('lint dirty modules only', () => {
       expect(stats.hasErrors()).toBe(true);
       const { errors } = stats.compilation;
       expect(errors.length).toBe(1);
-      const [{ message }] = errors;
-      expect(message).toEqual(expect.stringMatching('no-unused-vars'));
+      expect(stats.compilation.errors[0].message).toEqual(expect.stringMatching('no-unused-vars'));
       done();
     }
   });

test/lint-dirty-modules-only.test.js

@@ -48,9 +48,7 @@ describe('multiple instances', () => {
       },
     );
 
-    const stats = await compiler.runAsync();
-    expect(stats.hasWarnings()).toBe(false);
-    expect(stats.hasErrors()).toBe(true);
+    await expect(compiler.runAsync()).rejects.toThrow();
   });
 
   it('should fail on second instance', async () => {
@@ -73,8 +71,6 @@ describe('multiple instances', () => {
       },
     );
 
-    const stats = await compiler.runAsync();
-    expect(stats.hasWarnings()).toBe(false);
-    expect(stats.hasErrors()).toBe(true);
+    await expect(compiler.runAsync()).rejects.toThrow();
   });
 });

test/multiple-instances.test.js

@@ -21,6 +21,7 @@ export default (entry, pluginConf = {}, webpackConf = {}) => {
         ignore: false,
         // TODO: update tests to run both states: test.each([[{threads: false}], [{threads: true}]])('it should...', async ({threads}) => {...})
         threads: true,
+        failOnError: false,
         ...pluginConf,
       }),
     ],